Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2176)

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/sanitizers/sanitizers.gni
diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni
index 32cecffcae1e3ecf9ba178625a873add8a96833a..dddd9938381b635f1661732bba57d379557dd0e1 100644
--- a/build/config/sanitizers/sanitizers.gni
+++ b/build/config/sanitizers/sanitizers.gni
@@ -9,8 +9,8 @@ declare_args() {
# Compile for Leak Sanitizer to find leaks.
is_lsan = false
- # Compile for Memory Sanitizer to find uninitialized reads.
- is_msan = false
+ # is_msan is declared in //build/config/BUILDCONFIG.gn; see the comments
+ # in that file for why that is.
# Compile for Thread Sanitizer to find threading bugs.
is_tsan = false
@@ -128,3 +128,6 @@ prebuilt_instrumented_libraries_available =
# For one-off testing, just comment this assertion out.
assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr),
"Sanitizers should generally be used in release (set is_debug=false).")
+
+assert(!is_msan || (is_linux && current_cpu == "x64"),
+ "MSan currently only works on 64-bit Linux and ChromeOS builds.")

Powered by Google App Engine
This is Rietveld 408576698