Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: build/config/sanitizers/sanitizers.gni

Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 declare_args() { 5 declare_args() {
6 # Compile for Address Sanitizer to find memory bugs. 6 # Compile for Address Sanitizer to find memory bugs.
7 is_asan = false 7 is_asan = false
8 8
9 # Compile for Leak Sanitizer to find leaks. 9 # Compile for Leak Sanitizer to find leaks.
10 is_lsan = false 10 is_lsan = false
11 11
12 # Compile for Memory Sanitizer to find uninitialized reads. 12 # is_msan is declared in //build/config/BUILDCONFIG.gn; see the comments
13 is_msan = false 13 # in that file for why that is.
14 14
15 # Compile for Thread Sanitizer to find threading bugs. 15 # Compile for Thread Sanitizer to find threading bugs.
16 is_tsan = false 16 is_tsan = false
17 17
18 # Compile for Undefined Behaviour Sanitizer to find various types of 18 # Compile for Undefined Behaviour Sanitizer to find various types of
19 # undefined behaviour (excludes vptr checks). 19 # undefined behaviour (excludes vptr checks).
20 is_ubsan = false 20 is_ubsan = false
21 21
22 # Halt the program if a problem is detected. 22 # Halt the program if a problem is detected.
23 is_ubsan_no_recover = false 23 is_ubsan_no_recover = false
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 # 121 #
122 # If you find a use-case where you want to compile a sanitizer in debug mode 122 # If you find a use-case where you want to compile a sanitizer in debug mode
123 # and have verified it works, ask brettw and we can consider removing it from 123 # and have verified it works, ask brettw and we can consider removing it from
124 # this condition. We may also be able to find another way to enable your case 124 # this condition. We may also be able to find another way to enable your case
125 # without having people accidentally get broken builds by compiling an 125 # without having people accidentally get broken builds by compiling an
126 # unsupported or unadvisable configurations. 126 # unsupported or unadvisable configurations.
127 # 127 #
128 # For one-off testing, just comment this assertion out. 128 # For one-off testing, just comment this assertion out.
129 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr), 129 assert(!is_debug || !(is_msan || is_ubsan || is_ubsan_null || is_ubsan_vptr),
130 "Sanitizers should generally be used in release (set is_debug=false).") 130 "Sanitizers should generally be used in release (set is_debug=false).")
131
132 assert(!is_msan || (is_linux && current_cpu == "x64"),
133 "MSan currently only works on 64-bit Linux and ChromeOS builds.")
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698