Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: build/toolchain/linux/BUILD.gn

Issue 2116183002: Land chromium-side work to clean up handling of v8_target_cpu in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/toolchain/linux/BUILD.gn
diff --git a/build/toolchain/linux/BUILD.gn b/build/toolchain/linux/BUILD.gn
index 1fe3c7d526962c62faaaf30aec73387e15c1f62a..51e26cfce4d635a1317ee029503ccb2d44042b6a 100644
--- a/build/toolchain/linux/BUILD.gn
+++ b/build/toolchain/linux/BUILD.gn
@@ -38,6 +38,12 @@ clang_toolchain("clang_x86") {
toolchain_os = "linux"
}
+clang_toolchain("clang_x86_v8_arm") {
Michael Achenbach 2016/07/07 07:24:23 Should we add here the other combinations we use i
Dirk Pranke 2016/07/07 17:28:12 You can do either as you like. It might be easier
michaelbai 2016/07/07 18:41:26 Yes, We need define x86_v8_mipsel and x64_v8_mips6
+ toolchain_cpu = "x86"
+ v8_toolchain_cpu = "arm"
+ toolchain_os = "linux"
+}
+
gcc_toolchain("x86") {
cc = "gcc"
cxx = "g++"
@@ -57,6 +63,12 @@ clang_toolchain("clang_x64") {
toolchain_os = "linux"
}
+clang_toolchain("clang_x64_v8_arm64") {
+ toolchain_cpu = "x64"
+ v8_toolchain_cpu = "arm64"
+ toolchain_os = "linux"
+}
+
gcc_toolchain("x64") {
cc = "gcc"
cxx = "g++"

Powered by Google App Engine
This is Rietveld 408576698