third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html - Issue 2115013002: Include column rules for LayoutMultiColumnSet paint invalidation rects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html

Issue 2115013002: Include column rules for LayoutMultiColumnSet paint invalidation rects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height-expected.html » ('j') | third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html

diff --git a/third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html b/third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html

index d200f148a0ec3431a4185e22e5b09778de1f5008..cf17575dc40d63b3d6de7973a8ed168adffd2b41 100644

--- a/third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html

+++ b/third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html

@@ -1,9 +1,16 @@

<!DOCTYPE html>

+<script src="../../fast/repaint/resources/text-based-repaint.js"></script>

<p>There should be a blue square below. To the right of the square there should be two blue vertical

wkorman 2016/07/01 19:32:24 Is this text up to date? It doesn't match what I s

chrishtr 2016/07/01 22:31:32 Adjusted.

lines, with the same height as the square.</p>

-<div style="-webkit-columns:3; -webkit-column-rule:5px solid blue; -webkit-column-gap:5px; width:310px; height:315px; line-height:50px;">

+<div id="target" style="-webkit-columns:3; -webkit-column-rule:5px solid blue; -webkit-column-gap:5px; width:310px; height:315px; line-height:50px;">

</div>

+<script>

+onload = runRepaintAndPixelTest;

+function repaintTest() {

+ target.style.webkitColumnRule = "5px solid red";

+</script>