third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h - Issue 2115013002: Include column rules for LayoutMultiColumnSet paint invalidation rects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

Issue 2115013002: Include column rules for LayoutMultiColumnSet paint invalidation rects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html ('K') | « third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

index 62b94dbc0efbf9ae006ee20eeaf645ee66023307..d337f2e89f3e066daae49c9a4e7e71a4f0aaaa16 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h

@@ -170,6 +170,12 @@ public:

const char* name() const override { return "LayoutMultiColumnSet"; }

+ // Sets |columnBounds| to the bounds of each column rule rect's painted extent, adjusted by paint offset,

wkorman 2016/07/01 19:32:24 |columnBounds| -> |columnRuleBounds|

chrishtr 2016/07/01 22:31:32 Done.

+ // before pixel snapping. Retuns true if column rules should be painted at all.

wkorman 2016/07/01 19:32:24 Retuns -> Returns

chrishtr 2016/07/01 22:31:32 Done.

+ bool computeColumnRuleBounds(const LayoutPoint& paintOffset, Vector<LayoutRect>& columnRuleBounds) const;

+ LayoutRect localOverflowRectForPaintInvalidation() const override;

protected:

LayoutMultiColumnSet(LayoutFlowThread*);