third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html - Issue 2115013002: Include column rules for LayoutMultiColumnSet paint invalidation rects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height.html

Issue 2115013002: Include column rules for LayoutMultiColumnSet paint invalidation rects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/multicol/column-rules-fixed-height-expected.html » ('j') | third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

	2 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>

2 <p>There should be a blue square below. To the right of the square there should be two blue vertical	3 <p>There should be a blue square below. To the right of the square there should be two blue vertical
	wkorman 2016/07/01 19:32:24 Is this text up to date? It doesn't match what I s Is this text up to date? It doesn't match what I see in expected png. chrishtr 2016/07/01 22:31:32 Adjusted. Show quoted text On 2016/07/01 at 19:32:24, wkorman wrote: > Is this text up to date? It doesn't match what I see in expected png. Adjusted.
3 lines, with the same height as the square.</p>	4 lines, with the same height as the square.</p>

4 <div style="-webkit-columns:3; -webkit-column-rule:5px solid blue; -webkit-colum n-gap:5px; width:310px; height:315px; line-height:50px;">	5 <div id="target" style="-webkit-columns:3; -webkit-column-rule:5px solid blue; - webkit-column-gap:5px; width:310px; height:315px; line-height:50px;">

5 <div style="height:945px; background:blue;"></div>	6 <div style="height:945px; background:blue;"></div>

6 <br><br><br><br><br><br>	7 <br><br><br><br><br><br>

7 <br><br><br><br><br><br>	8 <br><br><br><br><br><br>

8 <br><br><br><br><br><br>	9 <br><br><br><br><br><br>

9 </div>	10 </div>

	11 <script>

	12 onload = runRepaintAndPixelTest;

	13 function repaintTest() {

	14 target.style.webkitColumnRule = "5px solid red";

	15 }

	16 </script>

OLD	NEW