Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2114793002: Relanding MD Settings: Improve rendering performance of fonts page. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dcheng, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@revert_paper_item
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relanding MD Settings: Improve rendering performance of fonts page. First version of this CL was reverted (cl/2119733002). The fonts page includes a few very large <settings-dropdown-menu> instances. While implementing force-rendering for the purposes of "search within settings" it was revealed that it occupied about 1.3s of the main thread to render itself. There are two separate improvements bundled in this CL. 1) Replace <paper-item> with a simple styled <div>. This change alone reduces total rendering time from 1.3s to 0.25s. 2) Use the new initialCount feature for dom-repeat to yield, instead of rendering the entire template all at once. BUG=602896, 608535 TEST=Click on "Customize fonts", observe how much faster the subpage opens. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d516b7a2c3b7c11aedd23522b34e6cfbb7916df5 Cr-Commit-Position: refs/heads/master@{#403366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 3 chunks +18 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
dpapad
4 years, 5 months ago (2016-06-30 22:51:44 UTC) #4
michaelpg
lgtm
4 years, 5 months ago (2016-06-30 22:56:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2114793002/1
4 years, 5 months ago (2016-06-30 23:44:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 00:24:40 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 00:24:42 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 00:26:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d516b7a2c3b7c11aedd23522b34e6cfbb7916df5
Cr-Commit-Position: refs/heads/master@{#403366}

Powered by Google App Engine
This is Rietveld 408576698