Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2119733002: Revert "MD Settings: Improve rendering performance of fonts page." (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, asanka, chromium-reviews, dbeam+watch-settings_chromium.org, dbeam+watch-downloads_chromium.org, dbeam+watch-polymer_chromium.org, dcheng, michaelpg+watch-md-ui_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-polymer_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "MD Settings: Improve rendering performance of fonts page." This reverts commit 9a07dc6b71462795d776490acb1e51142c9afd74. Broke styling of paper-item. BUG=624680 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9c8d8e76c18e1f0451269fe59bd71fb6be4701af Cr-Commit-Position: refs/heads/master@{#403335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -121 lines) Patch
M chrome/browser/resources/md_downloads/vulcanized.html View 12 chunks +64 lines, -56 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 3 chunks +8 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/chromium.patch View 1 chunk +0 lines, -49 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-item-shared-styles.html View 2 chunks +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
dpapad
Per offline discussion, I will send a separate CL to improve fonts page rendering, without ...
4 years, 5 months ago (2016-06-30 22:35:04 UTC) #3
michaelpg
lgtm
4 years, 5 months ago (2016-06-30 22:36:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2119733002/1
4 years, 5 months ago (2016-06-30 22:41:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 23:30:42 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 23:31:11 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 23:32:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c8d8e76c18e1f0451269fe59bd71fb6be4701af
Cr-Commit-Position: refs/heads/master@{#403335}

Powered by Google App Engine
This is Rietveld 408576698