Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: chrome/browser/resources/settings/controls/settings_dropdown_menu.html

Issue 2114793002: Relanding MD Settings: Improve rendering performance of fonts page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@revert_paper_item
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/settings_dropdown_menu.html
diff --git a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
index cc724f5cede26e2173d81c95c27a0e523ddc4ef0..716072b58f5b8550a363991a3422d6f61e76eb45 100644
--- a/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
+++ b/chrome/browser/resources/settings/controls/settings_dropdown_menu.html
@@ -1,6 +1,5 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/paper-dropdown-menu.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-listbox.html">
<link rel="import" href="/controls/pref_control_behavior.html">
<link rel="import" href="/i18n_setup.html">
@@ -10,9 +9,18 @@
<dom-module id="settings-dropdown-menu">
<template>
<style include="settings-shared">
- paper-item {
+ .item {
+ align-items: center;
color: var(--paper-grey-800);
+ display: flex;
font-size: inherit;
+ min-height: 48px;
+ padding: 0 16px;
+ }
+
+ .item:focus {
+ background-color: var(--paper-grey-300);
+ outline: none;
}
paper-dropdown-menu {
@@ -31,13 +39,17 @@
disabled="[[shouldDisableMenu_(disabled, menuOptions.*)]]">
<paper-listbox class="dropdown-content" selected="{{selected_}}"
attr-for-selected="data-value">
- <template is="dom-repeat" items="[[menuOptions]]">
- <paper-item data-value$="[[item.value]]">[[item.name]]</paper-item>
+ <template is="dom-repeat" items="[[menuOptions]]" initial-count="5">
+ <!--TODO(dpapad): Use <button class="paper-item">..</button> once it
+ lands in paper-item-shared-styles.html-->
+ <div class="item" role="option" data-value$="[[item.value]]">
+ [[item.name]]
+ </div>
</template>
- <paper-item data-value$="[[notFoundValue_]]"
+ <div class="item" role="option" data-value$="[[notFoundValue_]]"
hidden$="[[!isSelectedNotFound_(selected_)]]">
$i18n{custom}
- </paper-item>
+ </div>
</paper-listbox>
</paper-dropdown-menu>
</template>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698