Switch chrome_elf exception handling from breakpad to crashpad

Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows gypi build fixes.

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization using breakpad. Registering crashpad as the exception handling mechanism in chrome_elf.
   We continue to handle exceptions in chrome_elf in DllMain and in the blacklist interception code as before, i.e. we use crashpad to grab the dump and pass
   the exception to the next handler in the chain. I also added support in chrome_elf to not initialize crashpad if it is being loaded in some tests. For e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching on the exe and disallow the call. This is to prevent CRT from overwriting crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the chrome_elf_common target. Previously this dependency came in through the chrome_elf_breakpad target which has been deleted in this patch set.

BUG=604923, crashpad:106, 568664
TBR=sky

Committed: https://crrev.com/29f38cfc0afb51a04698c434f4bdcafd244f4270
Cr-Commit-Position: refs/heads/master@{#403519}

[ananta, 2016-06-30 02:46:00]

Description was changed from

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows gypi build fixes.

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception handling mechanism in
chrome_elf.
   We continue to handle exceptions in chrome_elf in DllMain and in the
blacklist interception code as before, i.e. we use crashpad to grab the dump and
pass
   the exception to the next handler in the chain. I also added support in
chrome_elf to not initialize crashpad if it is being loaded in some tests. For
e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

BUG=604923, crashpad:106, 568664
==========

to

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows gypi build fixes.

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception handling mechanism in
chrome_elf.
   We continue to handle exceptions in chrome_elf in DllMain and in the
blacklist interception code as before, i.e. we use crashpad to grab the dump and
pass
   the exception to the next handler in the chain. I also added support in
chrome_elf to not initialize crashpad if it is being loaded in some tests. For
e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has been deleted in this patch set.

BUG=604923, crashpad:106, 568664
==========

[ananta, 2016-06-30 02:52:07]

ananta@chromium.org changed reviewers:
+ robertshield@chromium.org, scottmg@chromium.org, sky@chromium.org

[ananta, 2016-06-30 02:52:07]

scottmg, robertshield, the only change from the previous patchset
https://codereview.chromium.org/2088133002/ is in blacklist.gypi where the
blacklist target depends on chrome_elf_common to address build errors in gyp
builds.

[ananta, 2016-06-30 02:53:04]

TBR'ing sky. Changes are only in chrome_elf/blacklist.gypi

[ananta, 2016-06-30 02:53:22]

Description was changed from

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows gypi build fixes.

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception handling mechanism in
chrome_elf.
   We continue to handle exceptions in chrome_elf in DllMain and in the
blacklist interception code as before, i.e. we use crashpad to grab the dump and
pass
   the exception to the next handler in the chain. I also added support in
chrome_elf to not initialize crashpad if it is being loaded in some tests. For
e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has been deleted in this patch set.

BUG=604923, crashpad:106, 568664
==========

to

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows gypi build fixes.

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception handling mechanism in
chrome_elf.
   We continue to handle exceptions in chrome_elf in DllMain and in the
blacklist interception code as before, i.e. we use crashpad to grab the dump and
pass
   the exception to the next handler in the chain. I also added support in
chrome_elf to not initialize crashpad if it is being loaded in some tests. For
e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has been deleted in this patch set.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

[scottmg, 2016-06-30 05:13:11]

diff to ps1 lgtm

[robertshield, 2016-06-30 18:29:31]

blacklist.gypi change lgtm

[ananta, 2016-07-01 19:46:50]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2016-07-01 19:47:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 20:46:45]

Description was changed from

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows gypi build fixes.

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception handling mechanism in
chrome_elf.
   We continue to handle exceptions in chrome_elf in DllMain and in the
blacklist interception code as before, i.e. we use crashpad to grab the dump and
pass
   the exception to the next handler in the chain. I also added support in
chrome_elf to not initialize crashpad if it is being loaded in some tests. For
e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has been deleted in this patch set.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

to

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows gypi build fixes.

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception handling mechanism in
chrome_elf.
   We continue to handle exceptions in chrome_elf in DllMain and in the
blacklist interception code as before, i.e. we use crashpad to grab the dump and
pass
   the exception to the next handler in the chain. I also added support in
chrome_elf to not initialize crashpad if it is being loaded in some tests. For
e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has been deleted in this patch set.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

[commit-bot: I haz the power, 2016-07-01 20:46:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-01 20:46:51]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 20:49:33]

Description was changed from

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows gypi build fixes.

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception handling mechanism in
chrome_elf.
   We continue to handle exceptions in chrome_elf in DllMain and in the
blacklist interception code as before, i.e. we use crashpad to grab the dump and
pass
   the exception to the next handler in the chain. I also added support in
chrome_elf to not initialize crashpad if it is being loaded in some tests. For
e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has been deleted in this patch set.

BUG=604923, crashpad:106, 568664
TBR=sky
==========

to

==========
Switch chrome_elf exception handling from breakpad to crashpad

Relanding this patch with windows gypi build fixes.

Switch chrome_elf exception handling from breakpad to crashpad.

Changes in this patch are as below:
1. chrome_elf: Removing breakpad and corresponding exception initialization
using breakpad. Registering crashpad as the exception handling mechanism in
chrome_elf.
   We continue to handle exceptions in chrome_elf in DllMain and in the
blacklist interception code as before, i.e. we use crashpad to grab the dump and
pass
   the exception to the next handler in the chain. I also added support in
chrome_elf to not initialize crashpad if it is being loaded in some tests. For
e.g. the
   ELFImportsTest. This is via the exe name check.

2. chrome.exe:- Removing crashpad exception registration. We need to retrieve
current exception reports information from chrome_elf instead of chrome.

3. Intercept the SetUnhandledExceptionFilter API in chrome_elf via IAT patching
on the exe and disallow the call. This is to prevent CRT from overwriting
crashpads exception
   filter. I added a TODO to see if we can use EAT patching or possibly sidestep
if we can support 64 bit with it.

4. Changed the browser lib target to depend on chrome_elf:blacklist instead of
chrome_elf. This	prevents chrome_elf from being implicitly loaded in processes
other
   than chrome.exe

5. Changed child_process_logging_win.cc to set the crash key trampolines from
chrome_elf instead of chrome.exe.

6. Changed the blacklist target in blacklist.gypi to depend on the
chrome_elf_common target. Previously this dependency came in through the
chrome_elf_breakpad target which has been deleted in this patch set.

BUG=604923, crashpad:106, 568664
TBR=sky

Committed: https://crrev.com/29f38cfc0afb51a04698c434f4bdcafd244f4270
Cr-Commit-Position: refs/heads/master@{#403519}
==========

[commit-bot: I haz the power, 2016-07-01 20:49:34]

Patchset 2 (id:??) landed as
https://crrev.com/29f38cfc0afb51a04698c434f4bdcafd244f4270
Cr-Commit-Position: refs/heads/master@{#403519}

[Kunihiko Sakamoto, 2016-07-04 06:04:11]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2123443002/ by ksakamoto@chromium.org.

The reason for reverting is: speculative revert to see whether this caused
crbug.com/625535.