chrome/app/chrome_main.cc - Issue 2114533002: Switch chrome_elf exception handling from breakpad to crashpad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/chrome_main.cc

Issue 2114533002: Switch chrome_elf exception handling from breakpad to crashpad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add dependencies on the chrome_elf_common target in the blacklist target. Previously this came in i… Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app/chrome_main.cc

diff --git a/chrome/app/chrome_main.cc b/chrome/app/chrome_main.cc

index 0ad602abf0cfccd9dab0605d129817b9bf2dbc9a..15d1e16551ce8a0847d1bd00a5686e64da59e9d1 100644

--- a/chrome/app/chrome_main.cc

+++ b/chrome/app/chrome_main.cc

@@ -62,8 +62,9 @@ int ChromeMain(int argc, const char** argv) {

// function correctly.

typedef void (__cdecl *DumpProcessFunction)();

DumpProcessFunction DumpProcess = reinterpret_cast<DumpProcessFunction>(

- ::GetProcAddress(::GetModuleHandle(chrome::kBrowserProcessExecutableName),

+ ::GetProcAddress(::GetModuleHandle(chrome::kChromeElfDllName),

"DumpProcessWithoutCrash"));

+ CHECK(DumpProcess);

base::debug::SetDumpWithoutCrashingFunction(DumpProcess);

#else

params.argc = argc;

« no previous file with comments | « chrome/app/chrome_exe_main_win.cc ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »