Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: components/crash/content/app/crashpad.cc

Issue 2114533002: Switch chrome_elf exception handling from breakpad to crashpad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add dependencies on the chrome_elf_common target in the blacklist target. Previously this came in i… Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_elf/chrome_elf_main.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/crashpad.cc
diff --git a/components/crash/content/app/crashpad.cc b/components/crash/content/app/crashpad.cc
index 72d68fb89ab1d755238deddc883c80a829ab225e..85afe46af675145d2b1251ea5a3b9e5989123eb2 100644
--- a/components/crash/content/app/crashpad.cc
+++ b/components/crash/content/app/crashpad.cc
@@ -228,15 +228,10 @@ void InitializeCrashpadImpl(bool initial_client,
g_simple_string_dictionary = new crashpad::SimpleStringDictionary();
crashpad_info->set_simple_annotations(g_simple_string_dictionary);
-#if !defined(OS_WIN) || !defined(COMPONENT_BUILD)
- // chrome/common/child_process_logging_win.cc registers crash keys for
- // chrome.dll. In a component build, that is sufficient as chrome.dll and
- // chrome.exe share a copy of base (in base.dll). In a static build, the EXE
- // must separately initialize the crash keys configuration as it has its own
- // statically linked copy of base.
+ // On Windows chrome_elf registers crash keys. This should work identically
+ // for component and non component builds.
base::debug::SetCrashKeyReportingFunctions(SetCrashKeyValue, ClearCrashKey);
crash_reporter_client->RegisterCrashKeys();
-#endif
SetCrashKeyValue("ptype", browser_process ? base::StringPiece("browser")
: base::StringPiece(process_type));
« no previous file with comments | « chrome_elf/chrome_elf_main.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698