Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2113953002: Merge "Improve performance to remove an OPTION from a SELECT element." to M52 (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge "Improve performance to remove an OPTION from a SELECT element." to M52 This CL optimize HTMLSelectElement::resetToDefaultSelection(). We can quit the loop if a selected OPTION was removed. Removing 20,000 OPTIONs: 7,595ms -> 6,358ms BUG=620142, 624220 Review-Url: https://codereview.chromium.org/2108883003 Cr-Commit-Position: refs/heads/master@{#402709} (cherry picked from commit 6aa050448c3f5a8e6749e059ec9ec62adb685a70) Committed: https://chromium.googlesource.com/chromium/src/+/ee4ea0dc58d29004697c7357dc7aadca01f74c03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 5 months ago (2016-07-01 05:40:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee4ea0dc58d29004697c7357dc7aadca01f74c03.

Powered by Google App Engine
This is Rietveld 408576698