Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2108883003: Improve performance to remove an OPTION from a SELECT element. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve performance to remove an OPTION from a SELECT element. This CL optimize HTMLSelectElement::resetToDefaultSelection(). We can quit the loop if a selected OPTION was removed. Removing 20,000 OPTIONs: 7,595ms -> 6,358ms BUG=620142, 624220 Committed: https://crrev.com/6aa050448c3f5a8e6749e059ec9ec62adb685a70 Cr-Commit-Position: refs/heads/master@{#402709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-06-29 01:32:19 UTC) #2
keishi
LGTM
4 years, 5 months ago (2016-06-29 02:36:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108883003/1
4 years, 5 months ago (2016-06-29 03:25:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 04:11:10 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 04:14:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6aa050448c3f5a8e6749e059ec9ec62adb685a70
Cr-Commit-Position: refs/heads/master@{#402709}

Powered by Google App Engine
This is Rietveld 408576698