third_party/WebKit/Source/core/html/HTMLSelectElement.h - Issue 2113953002: Merge "Improve performance to remove an OPTION from a SELECT element." to M52

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2113953002: Merge "Improve performance to remove an OPTION from a SELECT element." to M52 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.h b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

index 9fd2ac44415bc0f6342a1e33442f90835fc2427b..b40b12eaab56ae333d8adb19a631369f88ab7f7f 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.h

@@ -193,7 +193,11 @@ private:

void dispatchInputAndChangeEventForMenuList();

void recalcListItems() const;

- void resetToDefaultSelection();

+ enum ResetReason {

+ ResetReasonSelectedOptionRemoved,

+ ResetReasonOthers

+ };

+ void resetToDefaultSelection(ResetReason = ResetReasonOthers);

void typeAheadFind(KeyboardEvent*);

void saveLastSelection();

// Returns the first selected OPTION, or nullptr.

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »