Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2113893006: POC: Instrument task time tracker

Created:
4 years, 5 months ago by panicker
Modified:
4 years, 5 months ago
Reviewers:
Sami
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

POC: Instrument task time tracker BUG=

Patch Set 1 #

Patch Set 2 : remove empty lines, unused var #

Patch Set 3 : undo delegate delete #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -4 lines) Patch
M components/scheduler/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/scheduler/base/task_queue_manager.h View 1 3 chunks +6 lines, -1 line 0 comments Download
M components/scheduler/base/task_queue_manager.cc View 1 2 4 chunks +11 lines, -1 line 1 comment Download
A components/scheduler/base/task_time_tracker.h View 1 chunk +42 lines, -0 lines 0 comments Download
A components/scheduler/base/task_time_tracker.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M components/scheduler/child/scheduler_helper.h View 4 chunks +8 lines, -1 line 0 comments Download
M components/scheduler/child/scheduler_helper.cc View 3 chunks +11 lines, -1 line 0 comments Download
M components/scheduler/scheduler.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Sami
4 years, 5 months ago (2016-07-04 09:56:49 UTC) #2
Looks great.

https://codereview.chromium.org/2113893006/diff/40001/components/scheduler/ba...
File components/scheduler/base/task_queue_manager.cc (right):

https://codereview.chromium.org/2113893006/diff/40001/components/scheduler/ba...
components/scheduler/base/task_queue_manager.cc:50: timer_(new
base::DefaultTickClock()),
You might be able to read the time from real_time_domain_ instead of introducing
a new clock.

Powered by Google App Engine
This is Rietveld 408576698