Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: components/scheduler/base/task_queue_manager.cc

Issue 2113893006: POC: Instrument task time tracker Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: undo delegate delete Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/scheduler/base/task_queue_manager.h ('k') | components/scheduler/base/task_time_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/base/task_queue_manager.cc
diff --git a/components/scheduler/base/task_queue_manager.cc b/components/scheduler/base/task_queue_manager.cc
index 36f08de540fe8529ab593f6248504b0d23561795..eeaa0dc4cf3e54eceeb4365ca899fa4bc9b19062 100644
--- a/components/scheduler/base/task_queue_manager.cc
+++ b/components/scheduler/base/task_queue_manager.cc
@@ -14,6 +14,7 @@
#include "components/scheduler/base/task_queue_impl.h"
#include "components/scheduler/base/task_queue_manager_delegate.h"
#include "components/scheduler/base/task_queue_selector.h"
+#include "components/scheduler/base/task_time_tracker.h"
#include "components/scheduler/base/work_queue.h"
#include "components/scheduler/base/work_queue_sets.h"
@@ -38,12 +39,16 @@ TaskQueueManager::TaskQueueManager(
scoped_refptr<TaskQueueManagerDelegate> delegate,
const char* tracing_category,
const char* disabled_by_default_tracing_category,
- const char* disabled_by_default_verbose_tracing_category)
+ const char* disabled_by_default_verbose_tracing_category,
+ TaskTimeTracker* task_time_tracker)
: real_time_domain_(new RealTimeDomain(tracing_category)),
delegate_(delegate),
task_was_run_on_quiescence_monitored_queue_(false),
work_batch_size_(1),
task_count_(0),
+ task_time_tracker_(new TaskTimeTracker()),
+ timer_(new base::DefaultTickClock()),
Sami 2016/07/04 09:56:49 You might be able to read the time from real_time_
+ next_task_start_time_(base::TimeTicks()),
tracing_category_(tracing_category),
disabled_by_default_tracing_category_(
disabled_by_default_tracing_category),
@@ -192,6 +197,7 @@ void TaskQueueManager::DoWork(base::TimeTicks run_time, bool from_main_thread) {
UpdateWorkQueues(false, nullptr);
internal::TaskQueueImpl::Task previous_task;
+ base::TimeTicks task_start_time = timer_->NowTicks();
for (int i = 0; i < work_batch_size_; i++) {
internal::WorkQueue* work_queue;
if (!SelectWorkQueueToService(&work_queue)) {
@@ -211,6 +217,10 @@ void TaskQueueManager::DoWork(base::TimeTicks run_time, bool from_main_thread) {
case ProcessTaskResult::TASK_QUEUE_MANAGER_DELETED:
return; // The TaskQueueManager got deleted, we must bail out.
}
+ base::TimeTicks task_end_time = timer_->NowTicks();
+ task_time_tracker_->ReportTaskTime(task_start_time, task_end_time);
+ task_start_time = task_end_time;
+
work_queue = nullptr; // The queue may have been unregistered.
UpdateWorkQueues(should_trigger_wakeup, &previous_task);
« no previous file with comments | « components/scheduler/base/task_queue_manager.h ('k') | components/scheduler/base/task_time_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698