Use FilePaths in content::DropData to avoid redundant conversions.

Use FilePaths in content::DropData to avoid redundant conversions.

BUG=none
R=jam@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260293

[dcheng, 2014-03-26 00:19:39]

I noticed a lot of redundant conversions when I was fixing some other bugs in
this area.

This gets rid of things like:
- Converting to/from UTF16, only to immediately convert it back (depending on
platform) when constructing FilePath.
- content/browser/web_contents converts FilePaths to string16s... which
content/browser/renderer_host promptly has to convert back into FilePaths.

[dcheng, 2014-03-26 00:20:38]

(I haven't converted the Mac/GTK ports yet. Curious to hear your comments on the
overall approach--specifically, whether or not it's OK to embed
ui::OSExchangeData::FileInfo in DropData before proceeding further)

[jam, 2014-03-26 16:54:38]

lgtm

[jam, 2014-03-26 16:55:42]

On 2014/03/26 00:20:38, dcheng wrote:
> (I haven't converted the Mac/GTK ports yet. Curious to hear your comments on
the
> overall approach--specifically, whether or not it's OK to embed
> ui::OSExchangeData::FileInfo in DropData before proceeding further)

it's always fine to use data structures from modules that sit below content
(like ui, base etc) instead of having duplicate data structures in the content
api

[dcheng, 2014-03-27 21:43:27]

Updated to fix build on other platforms.

I've moved ui::OSExchangeData::FileInfo into its own header, as several
platforms (Mac) don't build OSExchangeData.

+sky for OWNERS review of changes in ui/.

[sky, 2014-03-27 23:22:33]

LGTM

https://codereview.chromium.org/211383007/diff/140001/ui/base/dragdrop/file_i...
File ui/base/dragdrop/file_info.cc (right):

https://codereview.chromium.org/211383007/diff/140001/ui/base/dragdrop/file_i...
ui/base/dragdrop/file_info.cc:13: : path(path), display_name(display_name) {}
nit: since you wrapped, one param per line.

[dcheng, 2014-03-27 23:26:27]

https://codereview.chromium.org/211383007/diff/140001/ui/base/dragdrop/file_i...
File ui/base/dragdrop/file_info.cc (right):

https://codereview.chromium.org/211383007/diff/140001/ui/base/dragdrop/file_i...
ui/base/dragdrop/file_info.cc:13: : path(path), display_name(display_name) {}
On 2014/03/27 23:22:34, sky wrote:
> nit: since you wrapped, one param per line.

This is what clang-format prefers; I'm happy to change it per your review
comments, but it will likely just change back in the future unless clang-format
is changed. Let me know what you think.

[sky1, 2014-03-27 23:37:53]

If that is what clang-format says, go with it.

On Thu, Mar 27, 2014 at 4:26 PM,  <dcheng@chromium.org> wrote:
>
>
https://codereview.chromium.org/211383007/diff/140001/ui/base/dragdrop/file_i...
> File ui/base/dragdrop/file_info.cc (right):
>
>
https://codereview.chromium.org/211383007/diff/140001/ui/base/dragdrop/file_i...
> ui/base/dragdrop/file_info.cc:13: : path(path),
> display_name(display_name) {}
> On 2014/03/27 23:22:34, sky wrote:
>>
>> nit: since you wrapped, one param per line.
>
>
> This is what clang-format prefers; I'm happy to change it per your
> review comments, but it will likely just change back in the future
> unless clang-format is changed. Let me know what you think.
>
> https://codereview.chromium.org/211383007/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dcheng, 2014-03-27 23:40:53]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-03-27 23:42:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/211383007/140001

[dcheng, 2014-03-28 20:35:46]

The CQ bit was unchecked by dcheng@chromium.org

[dcheng, 2014-03-28 21:55:34]

Committed patchset #8 manually as r260293 (presubmit successful).