content/renderer/drop_data_builder.cc - Issue 211383007: Use FilePaths in content::DropData to avoid redundant conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/drop_data_builder.cc

Issue 211383007: Use FilePaths in content::DropData to avoid redundant conversions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clang-format Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/drop_data_builder.cc

diff --git a/content/renderer/drop_data_builder.cc b/content/renderer/drop_data_builder.cc

index f9e5c420d3ccdee07ac37950b23ae7006c7544a5..d2d45832cfa7952bee138aeec35a24437d7693fc 100644

--- a/content/renderer/drop_data_builder.cc

+++ b/content/renderer/drop_data_builder.cc

@@ -55,8 +55,9 @@ DropData DropDataBuilder::Build(const WebDragData& drag_data) {

break;

case WebDragData::Item::StorageTypeFilename:

// TODO(varunjain): This only works on chromeos. Support win/mac/gtk.

- result.filenames.push_back(

- DropData::FileInfo(item.filenameData, item.displayNameData));

+ result.filenames.push_back(ui::FileInfo(

+ base::FilePath::FromUTF16Unsafe(item.filenameData),

+ base::FilePath::FromUTF16Unsafe(item.displayNameData)));

break;

}