content/browser/renderer_host/render_view_host_unittest.cc - Issue 211383007: Use FilePaths in content::DropData to avoid redundant conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_unittest.cc

Issue 211383007: Use FilePaths in content::DropData to avoid redundant conversions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: clang-format Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_view_host_unittest.cc

diff --git a/content/browser/renderer_host/render_view_host_unittest.cc b/content/browser/renderer_host/render_view_host_unittest.cc

index b69c9c987a4a4c18d243dbabd560f0e590c96b69..40a1fb6157916619aeb80d57eb6c5b362f3e7db9 100644

--- a/content/browser/renderer_host/render_view_host_unittest.cc

+++ b/content/browser/renderer_host/render_view_host_unittest.cc

@@ -190,8 +190,8 @@ TEST_F(RenderViewHostTest, DragEnteredFileURLsStillBlocked) {

GURL dragged_file_url = net::FilePathToFileURL(dragged_file_path);

GURL sensitive_file_url = net::FilePathToFileURL(sensitive_file_path);

dropped_data.url = highlighted_file_url;

- dropped_data.filenames.push_back(DropData::FileInfo(

- base::UTF8ToUTF16(dragged_file_path.AsUTF8Unsafe()), base::string16()));

+ dropped_data.filenames.push_back(

+ ui::FileInfo(dragged_file_path, base::FilePath()));

rvh()->DragTargetDragEnter(dropped_data, client_point, screen_point,

blink::WebDragOperationNone, 0);