Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2113573002: Enable seamless cubemap on Mac Intel. (Closed)

Created:
4 years, 5 months ago by Zhenyao Mo
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable seamless cubemap on Mac Intel. BUG=597794, 606074 NOTRY=true TEST=eanbled webgl2 conformance tests CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d0cf15e974aff5aaf53df87079969f181948a099 Cr-Commit-Position: refs/heads/master@{#403294}

Patch Set 1 #

Patch Set 2 : Enable seamless cubemap on Mac Intel. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 chunks +7 lines, -10 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Ken Russell (switch to Gerrit)
lgtm
4 years, 5 months ago (2016-06-30 21:18:41 UTC) #3
Zhenyao Mo
This does not affect any other bots but Mac Intel bots. Landing with NOTRY not ...
4 years, 5 months ago (2016-06-30 21:21:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113573002/20001
4 years, 5 months ago (2016-06-30 21:21:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 21:27:31 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:28:52 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d0cf15e974aff5aaf53df87079969f181948a099
Cr-Commit-Position: refs/heads/master@{#403294}

Powered by Google App Engine
This is Rietveld 408576698