Revert of Build delegation for perf tryjobs - fix false account name

Revert of Build delegation for perf tryjobs - fix false account name  (patchset #2 id:10001 of https://codereview.chromium.org/2103133005/ )

Reason for revert:
Broken tryjobs.

Original issue's description:
> This CL attempts to implement build delegation for perf tryjobs.
> Currently, perf try jobs build on the same builder that runs the test.
> This is bad because often we want much slower performance characteristics on
> our perfbots than on our builders, and this makes the builds very slow or even impossible.
> 
> BUG= http://crbug.com/601699
> 
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/b89e76b0fd8bebe0ccd45aabf54dca49b3cf26b9
> Committed: https://chromium.googlesource.com/chromium/tools/build/+/f7f2bbca20726ccb4dbeed103e8d3b32c90b6d46

TBR=robertocn@chromium.org,sergeyberezin@chromium.org,dnj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= http://crbug.com/601699

Committed: https://chromium.googlesource.com/chromium/tools/build/+/5943731df518183ecd786378e727fca4f3c46e72

[Ziqi Xiong, 2016-06-30 01:09:08]

The CQ bit was checked by zxiong@google.com

[Ziqi Xiong, 2016-06-30 01:09:09]

Created Revert of Build delegation for perf tryjobs - fix false account name

[commit-bot: I haz the power, 2016-06-30 01:09:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 01:09:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 01:09:19]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[Sergey Berezin (google), 2016-06-30 02:13:11]

sergeyberezin@google.com changed reviewers:
+ sergeyberezin@google.com

[Sergey Berezin (google), 2016-06-30 02:13:11]

LGTM

[RobertoCN, 2016-06-30 18:07:21]

This revert might not be necessary anymore. Waiting on a tryjob to succeed after
a problem with the service account was fixed.

[RobertoCN, 2016-06-30 18:20:13]

On 2016/06/30 18:07:21, RobertoCN wrote:
> This revert might not be necessary anymore. Waiting on a tryjob to succeed
after
> a problem with the service account was fixed.

Actually, this is broken now for a different reason. See
https://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bise...
It seems build_state.is_completed is checking for stdout['status'] instead of
stdout['build']['status']

It might be a good idea to split the change to chromium_tests/api.py from this,
into another cl.

[RobertoCN, 2016-06-30 18:20:22]

The CQ bit was checked by robertocn@chromium.org

[RobertoCN, 2016-06-30 18:20:23]

lgtm

[commit-bot: I haz the power, 2016-06-30 18:20:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 18:20:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 18:20:51]

Failed to apply patch for
scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json:
While running git apply --index -3 -p1;
  error: patch failed:
scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json:310
  Falling back to three-way merge...
  Applied patch to
'scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json'
with conflicts.
  U
scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json

Patch:      
scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
Index:
scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
diff --git
a/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
index
a71dd292558457bf524bc820703b4043bad24a67..64bfdfcb5b1b44e428d37e3c55e0001a94caeb06
100644
---
a/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
+++
b/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
@@ -19,9 +19,9 @@
       "--git-cache-dir",
       "[GIT_CACHE]",
       "--issue",
-      "12345",
+      "12853011",
       "--patchset",
-      "20001",
+      "1",
       "--rietveld_server",
       "https://codereview.chromium.org",
       "--output_json",
@@ -229,66 +229,6 @@
   },
   {
     "cmd": [
-      "/opt/infra-tools/buildbucket",
-      "put",
-      "--host",
-      "cr-buildbucket.appspot.com",
-      "--service-account-json",
-      "/creds/service_accounts/service-account-chromium-bisect.json",
-      "{\"bucket\": \"master.tryserver.chromium.perf\",
\"client_operation_id\": \"123456\", \"parameters_json\":
\"{\\\"buildername\\\": \\\"linux_perf_bisect_builder\\\", \\\"properties\\\":
{\\\"build_archive_url\\\": \\\"gs://chrome-perf-tryjob/Linux
Builder/full-build-linuxf27fede2220bcd326aee3e86ddfd4ebd0fe58cb9123456.zip\\\",
\\\"clobber\\\": true, \\\"issue\\\": \\\"12345\\\",
\\\"parent_got_revision\\\": \\\"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\\\",
\\\"patch_storage\\\": \\\"rietveld\\\", \\\"patchset\\\": \\\"20001\\\",
\\\"rietveld\\\": \\\"https://codereview.chromium.org\\\"}}\", \"tags\":
[\"master:tryserver.chromium.perf\", \"user_agent:recipe\"]}"
-    ],
-    "name": "buildbucket.put",
-    "stdout": "/path/to/tmp/json",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@json.output@{@@@",
-      "@@@STEP_LOG_LINE@json.output@  \"results\": [@@@",
-      "@@@STEP_LOG_LINE@json.output@    {@@@",
-      "@@@STEP_LOG_LINE@json.output@      \"build\": {@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"bucket\": \"user.username\",
@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"created_by\":
\"user:username@example.com\", @@@",
-      "@@@STEP_LOG_LINE@json.output@        \"created_ts\":
\"1459200369835900\", @@@",
-      "@@@STEP_LOG_LINE@json.output@        \"id\": \"9016911228971028736\",
@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"parameters_json\":
\"{\\\"This_has_been\\\": \\\"removed\\\"}\", @@@",
-      "@@@STEP_LOG_LINE@json.output@        \"result_details_json\": \"null\",
@@@",
-      "@@@STEP_LOG_LINE@json.output@        \"status\": \"SCHEDULED\", @@@",
-      "@@@STEP_LOG_LINE@json.output@        \"status_changed_ts\":
\"1459200369835930\", @@@",
-      "@@@STEP_LOG_LINE@json.output@        \"updated_ts\":
\"1459200369835940\", @@@",
-      "@@@STEP_LOG_LINE@json.output@        \"utcnow_ts\":
\"1459200369962370\"@@@",
-      "@@@STEP_LOG_LINE@json.output@      }, @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"etag\":
\"\\\"8uCIh8TRuYs4vPN3iWmly9SJMqw\\\"\", @@@",
-      "@@@STEP_LOG_LINE@json.output@      \"kind\":
\"buildbucket#resourcesItem\"@@@",
-      "@@@STEP_LOG_LINE@json.output@    }@@@",
-      "@@@STEP_LOG_LINE@json.output@  ]@@@",
-      "@@@STEP_LOG_LINE@json.output@}@@@",
-      "@@@STEP_LOG_END@json.output@@@"
-    ]
-  },
-  {
-    "cmd": [
-      "/opt/infra-tools/buildbucket",
-      "get",
-      "--host",
-      "cr-buildbucket.appspot.com",
-      "9016911228971028736"
-    ],
-    "name": "buildbucket.get",
-    "stdout": "/path/to/tmp/json",
-    "~followup_annotations": [
-      "@@@STEP_LOG_LINE@json.output@{@@@",
-      "@@@STEP_LOG_LINE@json.output@  \"bucket\":
\"master.tryserver.chromium.perf\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"id\": \"9009962699124567824\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"result\": \"SUCCESS\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"status\": \"COMPLETED\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"status_changed_utc\": \"Mon Jun 13
19:32:37 2016\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"updated_utc\": \"Mon Jun 13 19:32:37
2016\", @@@",
-      "@@@STEP_LOG_LINE@json.output@  \"url\":
\"http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6537\",
@@@",
-      "@@@STEP_LOG_LINE@json.output@  \"utcnow_utc\": \"Tue Jun 21 21:33:56
2016\"@@@",
-      "@@@STEP_LOG_LINE@json.output@}@@@",
-      "@@@STEP_LOG_END@json.output@@@"
-    ]
-  },
-  {
-    "cmd": [
       "python",
       "-u",
       "\nimport os, sys\nfrom common import chromium_utils # Error? See
https://crbug.com/584783.\n\n\nif os.path.exists(sys.argv[1]):\n 
chromium_utils.RemoveDirectory(sys.argv[1])\n",
@@ -310,22 +250,68 @@
     "cmd": [
       "python",
       "-u",
+      "[SLAVE_BUILD]/src/tools/mb/mb.py",
+      "gen",
+      "-m",
+      "tryserver.chromium.perf",
+      "-b",
+      "linux_perf_bisect",
+      "--config-file",
+      "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",
+      "--goma-dir",
+      "[CACHE]/cipd/goma",
+      "//out/Release"
+    ],
+    "env": {
+      "GOMA_SERVICE_ACCOUNT_JSON_FILE":
"/creds/service_accounts/service-account-goma-client.json"
+    },
+    "name": "generate_build_files (with patch)"
+  },
+  {
+    "cmd": [
+      "python",
+      "-u",
       "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",
       "--show-path",
       "python",
-      "RECIPE_PACKAGE_REPO[build]/scripts/slave/extract_build.py",
+      "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",
       "--gsutil-py-path",
       "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",
+      "--ninja-path",
+      "RECIPE_PACKAGE_REPO[depot_tools]/ninja",
       "--target",
       "Release",
-      "--build-archive-url",
-      "gs://chrome-perf-tryjob/Linux
Builder/full-build-linuxf27fede2220bcd326aee3e86ddfd4ebd0fe58cb9123456.zip",
-      "--master-name",
-      "tryserver.chromium.perf",
-      "--build-number",
-      "571"
-    ],
-    "name": "extract build"
+      "--src-dir",
+      "[SLAVE_BUILD]/src",
+      "--goma-cache-dir",
+      "[GOMA_CACHE]",
+      "--build-tool",
+      "ninja",
+      "--compiler",
+      "goma",
+      "--goma-jsonstatus",
+      "/path/to/tmp/json",
+      "--goma-service-account-json-file",
+      "/creds/service_accounts/service-account-goma-client.json",
+      "--mode",
+      "official",
+      "--goma-dir",
+      "[CACHE]/cipd/goma",
+      "--goma-hermetic",
+      "fallback",
+      "--goma-fail-fast",
+      "--goma-disable-local-fallback",
+      "--",
+      "chromium_builder_perf"
+    ],
+    "env": {
+      "GOMA_SERVICE_ACCOUNT_JSON_FILE":
"/creds/service_accounts/service-account-goma-client.json"
+    },
+    "name": "compile (with patch)",
+    "~followup_annotations": [
+      "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
+      "@@@STEP_LOG_END@json.output (invalid)@@@"
+    ]
   },
   {
     "cmd": [
@@ -336,9 +322,9 @@
       "Release",
       "--xvfb",
       "--factory-properties",
-      "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"],
\"branch\": \"\", \"buildername\": \"linux_perf_bisect\", \"buildnumber\": 571,
\"is_test\": true, \"issue\": \"12345\", \"mastername\":
\"tryserver.chromium.perf\", \"patch_project\": \"chromium\", \"patch_storage\":
\"rietveld\", \"patchset\": \"20001\", \"project\": \"chrome\", \"recipe\":
\"bisection/desktop_bisect\", \"repository\": \"\", \"requester\":
\"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\":
\"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\",
\"workdir\": \"/path/to/workdir/TestSlavename\"}",
+      "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"],
\"branch\": \"\", \"buildername\": \"linux_perf_bisect\", \"buildnumber\": 571,
\"issue\": 12853011, \"mastername\": \"tryserver.chromium.perf\",
\"patch_project\": \"chromium\", \"patchset\": 1, \"project\": \"chrome\",
\"recipe\": \"bisection/desktop_bisect\", \"repository\": \"\", \"requester\":
\"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\":
\"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\",
\"workdir\": \"/path/to/workdir/TestSlavename\"}",
       "--build-properties",
-      "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"],
\"branch\": \"\", \"buildername\": \"linux_perf_bisect\", \"buildnumber\": 571,
\"is_test\": true, \"issue\": \"12345\", \"mastername\":
\"tryserver.chromium.perf\", \"patch_project\": \"chromium\", \"patch_storage\":
\"rietveld\", \"patchset\": \"20001\", \"project\": \"chrome\", \"recipe\":
\"bisection/desktop_bisect\", \"repository\": \"\", \"requester\":
\"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\":
\"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\",
\"workdir\": \"/path/to/workdir/TestSlavename\"}",
+      "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"],
\"branch\": \"\", \"buildername\": \"linux_perf_bisect\", \"buildnumber\": 571,
\"issue\": 12853011, \"mastername\": \"tryserver.chromium.perf\",
\"patch_project\": \"chromium\", \"patchset\": 1, \"project\": \"chrome\",
\"recipe\": \"bisection/desktop_bisect\", \"repository\": \"\", \"requester\":
\"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\":
\"https://codereview.chromium.org\", \"slave…
(message too large)

[Ziqi Xiong, 2016-06-30 18:41:13]

The CQ bit was checked by zxiong@google.com

[Ziqi Xiong, 2016-06-30 18:41:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertocn@chromium.org, sergeyberezin@google.com
Link to the patchset: https://codereview.chromium.org/2113553002/#ps330001
(title: "Manually reverting")

[commit-bot: I haz the power, 2016-06-30 18:41:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 18:41:59]

Description was changed from

==========
Revert of Build delegation for perf tryjobs - fix false account name  (patchset
#2 id:10001 of https://codereview.chromium.org/2103133005/ )

Reason for revert:
Broken tryjobs.

Original issue's description:
> This CL attempts to implement build delegation for perf tryjobs.
> Currently, perf try jobs build on the same builder that runs the test.
> This is bad because often we want much slower performance characteristics on
> our perfbots than on our builders, and this makes the builds very slow or even
impossible.
> 
> BUG= http://crbug.com/601699
> 
> Committed:
https://chromium.googlesource.com/chromium/tools/build/+/b89e76b0fd8bebe0ccd4...
> Committed:
https://chromium.googlesource.com/chromium/tools/build/+/f7f2bbca20726ccb4dbe...

TBR=robertocn@chromium.org,sergeyberezin@chromium.org,dnj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= http://crbug.com/601699
==========

to

==========
Revert of Build delegation for perf tryjobs - fix false account name  (patchset
#2 id:10001 of https://codereview.chromium.org/2103133005/ )

Reason for revert:
Broken tryjobs.

Original issue's description:
> This CL attempts to implement build delegation for perf tryjobs.
> Currently, perf try jobs build on the same builder that runs the test.
> This is bad because often we want much slower performance characteristics on
> our perfbots than on our builders, and this makes the builds very slow or even
impossible.
> 
> BUG= http://crbug.com/601699
> 
> Committed:
https://chromium.googlesource.com/chromium/tools/build/+/b89e76b0fd8bebe0ccd4...
> Committed:
https://chromium.googlesource.com/chromium/tools/build/+/f7f2bbca20726ccb4dbe...

TBR=robertocn@chromium.org,sergeyberezin@chromium.org,dnj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= http://crbug.com/601699

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/5943731df518183ecd78...
==========

[commit-bot: I haz the power, 2016-06-30 18:42:17]

Committed patchset #2 (id:330001) as
https://chromium.googlesource.com/chromium/tools/build/+/5943731df518183ecd78...