Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2103133005: Build delegation for perf tryjobs - fix false account name (Closed)

Created:
4 years, 5 months ago by Ziqi Xiong
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

This CL attempts to implement build delegation for perf tryjobs. Currently, perf try jobs build on the same builder that runs the test. This is bad because often we want much slower performance characteristics on our perfbots than on our builders, and this makes the builds very slow or even impossible. BUG= http://crbug.com/601699 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b89e76b0fd8bebe0ccd45aabf54dca49b3cf26b9 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f7f2bbca20726ccb4dbeed103e8d3b32c90b6d46

Patch Set 1 #

Patch Set 2 : Update simulation test expectation files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7611 lines, -6032 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/perf_try/__init__.py View 1 2 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/perf_try/api.py View 1 4 chunks +153 lines, -7 lines 0 comments Download
A scripts/slave/recipe_modules/perf_try/build_state.py View 1 1 chunk +54 lines, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 1 6 chunks +110 lines, -25 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_fyi_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus6_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus7_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus9_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_one_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_cq.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_webview_arm64_aosp_perf_bisect.json View 1 4 chunks +7 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json View 1 9 chunks +192 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json View 1 9 chunks +154 lines, -128 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 1 10 chunks +110 lines, -199 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.py View 1 5 chunks +91 lines, -7 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json View 1 8 chunks +172 lines, -108 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json View 1 8 chunks +172 lines, -108 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json View 1 8 chunks +132 lines, -107 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json View 1 8 chunks +172 lines, -108 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ziqi Xiong
This is the new CL for build delegation with correct account name. Thanks.
4 years, 5 months ago (2016-06-28 23:42:01 UTC) #3
Sergey Berezin
lgtm for chromium_tests/api.py
4 years, 5 months ago (2016-06-29 01:07:23 UTC) #4
RobertoCN
lgtm
4 years, 5 months ago (2016-06-29 21:54:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103133005/10001
4 years, 5 months ago (2016-06-29 21:54:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:10001) as https://chromium.googlesource.com/chromium/tools/build/+/f7f2bbca20726ccb4dbeed103e8d3b32c90b6d46
4 years, 5 months ago (2016-06-29 22:00:27 UTC) #9
Ziqi Xiong
4 years, 5 months ago (2016-06-30 01:09:07 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:10001) has been created in
https://codereview.chromium.org/2113553002/ by zxiong@google.com.

The reason for reverting is: Broken tryjobs..

Powered by Google App Engine
This is Rietveld 408576698