src/interpreter/bytecode-array-writer.h - Issue 2112853002: Do not record source positions for non-JS or native script code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-writer.h

Issue 2112853002: Do not record source positions for non-JS or native script code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@simplifyjitlogging

Patch Set: update test expectation Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-array-writer.h

diff --git a/src/interpreter/bytecode-array-writer.h b/src/interpreter/bytecode-array-writer.h

index c5200441c9054944b565bae103957e666a4a5640..49d83bb04eb4cdc9610e728761e43cd7c3db5129 100644

--- a/src/interpreter/bytecode-array-writer.h

+++ b/src/interpreter/bytecode-array-writer.h

@@ -22,8 +22,10 @@ class ConstantArrayBuilder;

// generation pipeline.

class BytecodeArrayWriter final : public BytecodePipelineStage {

public:

- BytecodeArrayWriter(Isolate* isolate, Zone* zone,

- ConstantArrayBuilder* constant_array_builder);

+ BytecodeArrayWriter(

+ Isolate* isolate, Zone* zone,

+ ConstantArrayBuilder* constant_array_builder,

+ SourcePositionTableBuilder::RecordingMode source_position_mode);

virtual ~BytecodeArrayWriter();

// BytecodePipelineStage interface.

« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/bytecode-array-writer.cc » ('j') | no next file with comments »