src/interpreter/bytecode-generator.cc - Issue 2112853002: Do not record source positions for non-JS or native script code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2112853002: Do not record source positions for non-JS or native script code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@simplifyjitlogging

Patch Set: update test expectation Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-generator.cc

diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc

index bdc5370f5a30ac5779f65f6999c3470256a712cf..9f9c7874953450ede7ea4ddb0aa1e6d7a8da1909 100644

--- a/src/interpreter/bytecode-generator.cc

+++ b/src/interpreter/bytecode-generator.cc

@@ -547,7 +547,8 @@ BytecodeGenerator::BytecodeGenerator(CompilationInfo* info)

builder_(new (zone()) BytecodeArrayBuilder(

info->isolate(), info->zone(), info->num_parameters_including_this(),

info->scope()->MaxNestedContextChainLength(),

- info->scope()->num_stack_slots(), info->literal())),

+ info->scope()->num_stack_slots(), info->literal(),

+ info->SourcePositionRecordingMode())),

info_(info),

scope_(info->scope()),

globals_(0, info->zone()),

« no previous file with comments | « src/interpreter/bytecode-array-writer.cc ('k') | src/source-position-table.h » ('j') | no next file with comments »