Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2112713003: Revert of Put RegExp js code in strict mode (patchset #2 id:20001 of https://codereview.chromium.or… (Closed)

Created:
4 years, 5 months ago by Dan Ehrenberg
Modified:
4 years, 5 months ago
Reviewers:
adamk, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Put RegExp js code in strict mode (patchset #2 id:20001 of https://codereview.chromium.org/1776883005/ ) Reason for revert: Found to break SAP Web IDE, and these semantics are not shipped in any other browser. Revert to legacy semantics while assessing web compatibility. BUG=chromium:624318 Original issue's description: > Put RegExp js code in strict mode > > src/js/regexp.js was one of the few files that was left in sloppy > mode. The ES2017 draft specification requires that writes to > lastIndex throw when the property is non-writable, and test262 > tests enforce this behavior. This patch puts that file in strict > mode. > > BUG=v8:4504 > R=yangguo@chromium.org > LOG=Y > > Committed: https://crrev.com/80b1b2a45bbd9bf3d08e4e6516acfaaa8f438213 > Cr-Commit-Position: refs/heads/master@{#34801} TBR=yangguo@chromium.org,adamk@chromium.org Committed: https://crrev.com/34880eb3dcf7492d44c0a3b45b6c888189f2c3c3 Cr-Commit-Position: refs/heads/master@{#37449}

Patch Set 1 #

Patch Set 2 : add more test262 failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M src/js/regexp.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/regexp-lastIndex.js View 1 chunk +0 lines, -18 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +16 lines, -0 lines 0 comments Download
M test/webkit/fast/regex/lastIndex-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112713003/1
4 years, 5 months ago (2016-06-29 22:15:42 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/4222) v8_linux_nodcheck_rel_ng_triggered on ...
4 years, 5 months ago (2016-06-29 22:34:01 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112713003/20001
4 years, 5 months ago (2016-06-30 01:54:55 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 02:19:43 UTC) #8
Dan Ehrenberg
This is a version of https://codereview.chromium.org/2106803004/ with test262.status fixed. Got lgtm there.
4 years, 5 months ago (2016-06-30 14:33:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112713003/20001
4 years, 5 months ago (2016-06-30 14:33:21 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-30 14:33:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112713003/20001
4 years, 5 months ago (2016-06-30 14:34:11 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 14:36:21 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 14:36:23 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/34880eb3dcf7492d44c0a3b45b6c888189f2c3c3 Cr-Commit-Position: refs/heads/master@{#37449}
4 years, 5 months ago (2016-06-30 14:36:48 UTC) #20
Dan Ehrenberg
4 years, 3 months ago (2016-09-15 03:30:06 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2344773002/ by littledan@chromium.org.

The reason for reverting is: With fixes for frozen RegExps in
https://codereview.chromium.org/2339443002 , it should be web-compatible to put
RegExps in strict mode again, per spec..

Powered by Google App Engine
This is Rietveld 408576698