Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2339443002: [regexp] Avoid unneeded accesses to lastIndex (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Avoid unneeded accesses to lastIndex This implements https://github.com/tc39/ecma262/pull/627/. BUG=v8:5360 Committed: https://crrev.com/8df547d4024025001323daae3c105861dce05015 Cr-Commit-Position: refs/heads/master@{#39402}

Patch Set 1 #

Patch Set 2 : Update test262 status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M src/js/regexp.js View 2 chunks +9 lines, -11 lines 0 comments Download
M test/mjsunit/regexp.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-2437.js View 5 chunks +7 lines, -7 lines 0 comments Download
M test/mjsunit/regress/regress-2438.js View 1 chunk +8 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
jgruber
Three test262 tests need to be updated for this change (see test262.status).
4 years, 3 months ago (2016-09-13 13:24:33 UTC) #6
Dan Ehrenberg
lgtm Looks like a faithful implementation of the new spec to me. One follow-up would ...
4 years, 3 months ago (2016-09-13 17:53:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2339443002/20001
4 years, 3 months ago (2016-09-14 07:17:33 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 07:39:00 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 07:39:52 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8df547d4024025001323daae3c105861dce05015
Cr-Commit-Position: refs/heads/master@{#39402}

Powered by Google App Engine
This is Rietveld 408576698