Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2106803004: Revert of Put RegExp js code in strict mode (Closed)

Created:
4 years, 5 months ago by Dan Ehrenberg
Modified:
4 years, 5 months ago
Reviewers:
adamk, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Put RegExp js code in strict mode (patchset #2 id:20001 of https://codereview.chromium.org/1776883005/ ) Reason for revert: Found to break SAP Web IDE, and these semantics are not shipped in any other browser. Revert to legacy semantics while assessing web compatibility. BUG=chromium:624318 Original issue's description: > Put RegExp js code in strict mode > > src/js/regexp.js was one of the few files that was left in sloppy > mode. The ES2017 draft specification requires that writes to > lastIndex throw when the property is non-writable, and test262 > tests enforce this behavior. This patch puts that file in strict > mode. > > BUG=v8:4504 > R=yangguo@chromium.org > LOG=Y > > Committed: https://crrev.com/80b1b2a45bbd9bf3d08e4e6516acfaaa8f438213 > Cr-Commit-Position: refs/heads/master@{#34801} TBR=yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -23 lines) Patch
M src/js/regexp.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/regexp-lastIndex.js View 1 chunk +0 lines, -18 lines 0 comments Download
M test/test262/test262.status View 1 chunk +4 lines, -0 lines 0 comments Download
M test/webkit/fast/regex/lastIndex-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dan Ehrenberg
Created Revert of Put RegExp js code in strict mode
4 years, 5 months ago (2016-06-29 21:40:31 UTC) #1
Dan Ehrenberg
Should we revert this patch?
4 years, 5 months ago (2016-06-29 21:41:02 UTC) #3
adamk
reverting for now lgtm
4 years, 5 months ago (2016-06-29 21:46:51 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106803004/1
4 years, 5 months ago (2016-06-29 21:47:04 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/20138) v8_linux64_avx2_rel_ng on ...
4 years, 5 months ago (2016-06-29 21:48:35 UTC) #8
Yang
On 2016/06/29 21:48:35, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 5 months ago (2016-06-30 05:10:13 UTC) #9
Dan Ehrenberg
4 years, 5 months ago (2016-06-30 14:37:22 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698