Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp

Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: migrated to inspector-protocol test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
index 219e59124841166a7a69df176fac31d0b83b353f..268409b6fd8d82c98881eeb66dda847d8b864e7f 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp
@@ -37,7 +37,6 @@ V8InspectorSessionImpl::V8InspectorSessionImpl(V8DebuggerImpl* debugger, int con
, m_debugger(debugger)
, m_client(client)
, m_customObjectFormatterEnabled(false)
- , m_instrumentationCounter(0)
, m_dispatcher(channel)
, m_state(nullptr)
, m_runtimeAgent(nullptr)
@@ -246,16 +245,6 @@ void V8InspectorSessionImpl::reportAllContexts(V8RuntimeAgentImpl* agent)
agent->reportExecutionContextCreated(idContext.second.get());
}
-void V8InspectorSessionImpl::changeInstrumentationCounter(int delta)
-{
- DCHECK_GE(m_instrumentationCounter + delta, 0);
- if (!m_instrumentationCounter)
- m_client->startInstrumenting();
- m_instrumentationCounter += delta;
- if (!m_instrumentationCounter)
- m_client->stopInstrumenting();
-}
-
void V8InspectorSessionImpl::dispatchProtocolMessage(const String16& message)
{
m_dispatcher.dispatch(message);
@@ -295,11 +284,6 @@ void V8InspectorSessionImpl::breakProgram(const String16& breakReason, std::uniq
m_debuggerAgent->breakProgram(breakReason, std::move(data));
}
-void V8InspectorSessionImpl::breakProgramOnException(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data)
-{
- m_debuggerAgent->breakProgramOnException(breakReason, std::move(data));
-}
-
void V8InspectorSessionImpl::setSkipAllPauses(bool skip)
{
ErrorString errorString;

Powered by Google App Engine
This is Rietveld 408576698