third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp - Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: migrated to inspector-protocol test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

index b09f4f55ee24bf0025cfcd6e9ed3ff3a3b93b822..4e8d77976515f71463bbb162e8f2d9bf740b64f4 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

@@ -185,14 +185,12 @@ void V8ProfilerAgentImpl::enable(ErrorString*)

return;

m_enabled = true;

m_state->setBoolean(ProfilerAgentState::profilerEnabled, true);

- m_session->changeInstrumentationCounter(+1);

}

void V8ProfilerAgentImpl::disable(ErrorString* errorString)

{

if (!m_enabled)

return;

- m_session->changeInstrumentationCounter(-1);

for (size_t i = m_startedProfiles.size(); i > 0; --i)

stopProfiling(m_startedProfiles[i - 1].m_id, false);

m_startedProfiles.clear();

@@ -217,7 +215,6 @@ void V8ProfilerAgentImpl::restore()

if (!m_state->booleanProperty(ProfilerAgentState::profilerEnabled, false))

return;

m_enabled = true;

- m_session->changeInstrumentationCounter(+1);

int interval = 0;

m_state->getNumber(ProfilerAgentState::samplingInterval, &interval);

if (interval)