third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h - Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 2112593003: [DevTools] Remove [V8] from InspectorInstrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: migrated to inspector-protocol test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

index 225646b88e3cda287e93c26d5cd133515931282e..f031e7fc1b6164281999cb07d2a15d6dcc6d21cb 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

@@ -48,7 +48,6 @@ public:

void discardInjectedScripts();

void reportAllContexts(V8RuntimeAgentImpl*);

void setCustomObjectFormatterEnabled(bool);

- void changeInstrumentationCounter(int delta);

// V8InspectorSession implementation.

void dispatchProtocolMessage(const String16& message) override;

@@ -57,7 +56,6 @@ public:

void schedulePauseOnNextStatement(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data) override;

void cancelPauseOnNextStatement() override;

void breakProgram(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data) override;

- void breakProgramOnException(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data) override;

void setSkipAllPauses(bool) override;

void resume() override;

void stepOver() override;

@@ -77,7 +75,6 @@ private:

V8DebuggerImpl* m_debugger;

V8InspectorSessionClient* m_client;

bool m_customObjectFormatterEnabled;

- int m_instrumentationCounter;

protocol::UberDispatcher m_dispatcher;

std::unique_ptr<protocol::DictionaryValue> m_state;