Wire up invalidation for flood-{color,opacity} on <feDropShadow>

Wire up invalidation for flood-{color,opacity} on <feDropShadow>

Make sure to call primitiveAttributeChanged() for this element and
property combination. Implement the required infrastructure in
SVGFEDropShadowElement::setFilterEffectAttribute and FEDropShadow.

Because of an issue with SVGTestCase.js the tests below would not
previously fail as expected. That is being addressed by the CL at
https://codereview.chromium.org/2104943005.

TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
BUG=231560
Committed: https://crrev.com/e75f02434b1b3cfdd8ec0e0c3bbf4755c54a4b35
Cr-Commit-Position: refs/heads/master@{#403025}

[fs, 2016-06-29 17:36:18]

fs@opera.com changed reviewers:
+ pdr@chromium.org, schenney@chromium.org

[fs, 2016-06-29 17:36:19]

Found this oldie on my buglist, and figured I should knock it down. For some
reason, when run in the test-runner these tests don't fail, while they fail
reliably when run "normally" (in content_shell et.c.) I'm digging into that some
more.

[pdr., 2016-06-29 17:48:40]

Codechange LGTM

Curious what's up with the test runner though.

[fs, 2016-06-29 18:30:05]

On 2016/06/29 at 17:48:40, pdr wrote:
> Codechange LGTM
> 
> Curious what's up with the test runner though.

I think I located the source of that oddness...

In SVGTestCase.js we have this test-runner specific code [1] that adds a <style>
element and applies a 'running' class to the document root. This class in turn
enables a rule that sets 'display' to 'none' for a number of elements on the
page. In afterTest() 'running' is again removed (from the document root), which
causes the <svg> to be pushed down, and triggers a repaint... I'm running a CL
[2] through the bots to see if we can trivially rip it out (it doesn't seem
overly useful at a glance.)

[1]
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/svg/dynam...
[2] https://codereview.chromium.org/2104943005

[fs, 2016-06-29 19:54:35]

On 2016/06/29 at 18:30:05, fs wrote:
> On 2016/06/29 at 17:48:40, pdr wrote:
> > Codechange LGTM
> > 
> > Curious what's up with the test runner though.
> 
> I think I located the source of that oddness...
> 
> In SVGTestCase.js we have this test-runner specific code [1] that adds a
<style> element and applies a 'running' class to the document root. This class
in turn enables a rule that sets 'display' to 'none' for a number of elements on
the page. In afterTest() 'running' is again removed (from the document root),
which causes the <svg> to be pushed down, and triggers a repaint... I'm running
a CL [2] through the bots to see if we can trivially rip it out (it doesn't seem
overly useful at a glance.)
> 
> [1]
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/svg/dynam...
> [2] https://codereview.chromium.org/2104943005

That confirmed the bug in the tests - and revealed other possible issues (like
SVGPreserveAspectRatioTearOff seems to be missing commitChange() calls.)

I'll go ahead and land this now, verify the fix on the other CL and analyze/fix
the other issues found by that CL. (Will ref that CL from this description.)

[fs, 2016-06-29 19:56:54]

Description was changed from

==========
Wire up invalidation for flood-{color,opacity} on <feDropShadow>

Make sure to call primitiveAttributeChanged() for this element and
property combination. Implement the required infrastructure in
SVGFEDropShadowElement::setFilterEffectAttribute and FEDropShadow.

TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
BUG=231560
==========

to

==========
Wire up invalidation for flood-{color,opacity} on <feDropShadow>

Make sure to call primitiveAttributeChanged() for this element and
property combination. Implement the required infrastructure in
SVGFEDropShadowElement::setFilterEffectAttribute and FEDropShadow.

Because of an issue with SVGTestCase.js the tests below would not
previously fail as expected. That is being addressed by the CL at 
https://codereview.chromium.org/2104943005.

TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
BUG=231560
==========

[fs, 2016-06-29 19:57:02]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-06-29 19:59:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:27:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-30 00:27:32]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 00:29:41]

Description was changed from

==========
Wire up invalidation for flood-{color,opacity} on <feDropShadow>

Make sure to call primitiveAttributeChanged() for this element and
property combination. Implement the required infrastructure in
SVGFEDropShadowElement::setFilterEffectAttribute and FEDropShadow.

Because of an issue with SVGTestCase.js the tests below would not
previously fail as expected. That is being addressed by the CL at 
https://codereview.chromium.org/2104943005.

TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
BUG=231560
==========

to

==========
Wire up invalidation for flood-{color,opacity} on <feDropShadow>

Make sure to call primitiveAttributeChanged() for this element and
property combination. Implement the required infrastructure in
SVGFEDropShadowElement::setFilterEffectAttribute and FEDropShadow.

Because of an issue with SVGTestCase.js the tests below would not
previously fail as expected. That is being addressed by the CL at
https://codereview.chromium.org/2104943005.

TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
TEST=svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
BUG=231560

Committed: https://crrev.com/e75f02434b1b3cfdd8ec0e0c3bbf4755c54a4b35
Cr-Commit-Position: refs/heads/master@{#403025}
==========

[commit-bot: I haz the power, 2016-06-30 00:29:42]

Patchset 1 (id:??) landed as
https://crrev.com/e75f02434b1b3cfdd8ec0e0c3bbf4755c54a4b35
Cr-Commit-Position: refs/heads/master@{#403025}