Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2104943005: Drop the adding and removing of the 'running' class in SVGTestCase.js (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop the adding and removing of the 'running' class in SVGTestCase.js This class will trigger layouts that could hide the intended effects of the tests using this "framework". Since the same elements are marked as being hidden, this will not affect the graphical output. BUG=231560 Committed: https://crrev.com/75bcf4d0e655c40431996ec7972220ffc7ce92d3 Cr-Commit-Position: refs/heads/master@{#404380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/svg/dynamic-updates/resources/SVGTestCase.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
fs
This should hopefully be ready to go now - all roadblocks cleared *gives evil eye ...
4 years, 5 months ago (2016-07-07 23:11:49 UTC) #5
pdr.
On 2016/07/07 at 23:11:49, fs wrote: > This should hopefully be ready to go now ...
4 years, 5 months ago (2016-07-07 23:12:43 UTC) #6
fs
On 2016/07/07 at 23:12:43, pdr wrote: > On 2016/07/07 at 23:11:49, fs wrote: > > ...
4 years, 5 months ago (2016-07-08 11:08:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104943005/1
4 years, 5 months ago (2016-07-08 11:09:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 14:30:06 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 14:32:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75bcf4d0e655c40431996ec7972220ffc7ce92d3
Cr-Commit-Position: refs/heads/master@{#404380}

Powered by Google App Engine
This is Rietveld 408576698