Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp

Issue 2112563002: Wire up invalidation for flood-{color,opacity} on <feDropShadow> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp
index 851cf0d53b88a8b2c6c4d600d716e395b198804c..c2aa8c59428d6d9016b7d0716ac53ba5fd489523 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilterPrimitive.cpp
@@ -36,14 +36,12 @@ void LayoutSVGResourceFilterPrimitive::styleDidChange(StyleDifference diff, cons
LayoutObject* filter = parent();
if (!filter)
return;
- ASSERT(filter->isSVGResourceFilter());
-
+ DCHECK(filter->isSVGResourceFilter());
if (!oldStyle)
return;
-
- const SVGComputedStyle& newStyle = this->style()->svgStyle();
- ASSERT(element());
- if (isSVGFEFloodElement(*element())) {
+ const SVGComputedStyle& newStyle = this->styleRef().svgStyle();
+ DCHECK(element());
+ if (isSVGFEFloodElement(*element()) || isSVGFEDropShadowElement(*element())) {
if (newStyle.floodColor() != oldStyle->svgStyle().floodColor())
toLayoutSVGResourceFilter(filter)->primitiveAttributeChanged(this, SVGNames::flood_colorAttr);
if (newStyle.floodOpacity() != oldStyle->svgStyle().floodOpacity())
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698