third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed invisible to hidden to match ARIA Implementation Guide. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/accessibility/aria-relations-should-ignore-hidden-targets.html ('K') | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

index c46b62018e8f6e787b0f91d3034d514a6ac718d4..d2207945e2b17f96a7da83c5117e03a9f0a700e1 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

@@ -69,7 +69,7 @@ protected:

String ariaAccessibilityDescription() const;

String ariaAutoComplete() const;

AccessibilityRole determineAriaRoleAttribute() const;

- void accessibilityChildrenFromAttribute(QualifiedName attr, AXObject::AXObjectVector&) const;

+ void accessibilityChildrenFromAttribute(QualifiedName attr, AXObject::AXObjectVector&, bool) const;

aboxhall 2016/07/08 17:12:35 Perhaps instead of passing "includeHiddenObjects"

bool hasContentEditableAttributeSet() const;

bool isTextControl() const override;