third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target.

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed invisible to hidden to match ARIA Implementation Guide. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/accessibility/aria-relations-should-ignore-hidden-targets.html ('K') | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012, Google Inc. All rights reserved.	2 * Copyright (C) 2012, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override ;	62 bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override ;

63 const AXObject* inheritsPresentationalRoleFrom() const override;	63 const AXObject* inheritsPresentationalRoleFrom() const override;

64 virtual AccessibilityRole determineAccessibilityRole();	64 virtual AccessibilityRole determineAccessibilityRole();

65 virtual AccessibilityRole nativeAccessibilityRoleIgnoringAria() const;	65 virtual AccessibilityRole nativeAccessibilityRoleIgnoringAria() const;

66 String accessibilityDescriptionForElements(HeapVector<Member<Element>> &elem ents) const;	66 String accessibilityDescriptionForElements(HeapVector<Member<Element>> &elem ents) const;

67 void alterSliderValue(bool increase);	67 void alterSliderValue(bool increase);

68 AXObject* activeDescendant() override;	68 AXObject* activeDescendant() override;

69 String ariaAccessibilityDescription() const;	69 String ariaAccessibilityDescription() const;

70 String ariaAutoComplete() const;	70 String ariaAutoComplete() const;

71 AccessibilityRole determineAriaRoleAttribute() const;	71 AccessibilityRole determineAriaRoleAttribute() const;

72 void accessibilityChildrenFromAttribute(QualifiedName attr, AXObject::AXObje ctVector&) const;	72 void accessibilityChildrenFromAttribute(QualifiedName attr, AXObject::AXObje ctVector&, bool) const;
	aboxhall 2016/07/08 17:12:35 Perhaps instead of passing "includeHiddenObjects" Perhaps instead of passing "includeHiddenObjects" in, we could simply switch on "attr" in the method body? I don't see why the logic for determining this shouldn't live in the method rather than in the various calling methods. If you still want to pass it in, it should definitely have a name in the method signature.
73	73

74 bool hasContentEditableAttributeSet() const;	74 bool hasContentEditableAttributeSet() const;

75 bool isTextControl() const override;	75 bool isTextControl() const override;

76 // This returns true if it's focusable but it's not content editable and it' s not a control or ARIA control.	76 // This returns true if it's focusable but it's not content editable and it' s not a control or ARIA control.

77 bool isGenericFocusableElement() const;	77 bool isGenericFocusableElement() const;

78 AXObject* menuButtonForMenu() const;	78 AXObject* menuButtonForMenu() const;

79 Element* menuItemElementForMenu() const;	79 Element* menuItemElementForMenu() const;

80 Element* mouseButtonListener() const;	80 Element* mouseButtonListener() const;

81 AccessibilityRole remapAriaRoleDueToParent(AccessibilityRole) const;	81 AccessibilityRole remapAriaRoleDueToParent(AccessibilityRole) const;

82 bool isNativeCheckboxOrRadio() const;	82 bool isNativeCheckboxOrRadio() const;

(...skipping 128 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
211 bool isNativeCheckboxInMixedState() const;	211 bool isNativeCheckboxInMixedState() const;

212 String textFromDescendants(AXObjectSet& visited, bool recursive) const overr ide;	212 String textFromDescendants(AXObjectSet& visited, bool recursive) const overr ide;

213 String nativeTextAlternative(AXObjectSet& visited, AXNameFrom&, AXRelatedObj ectVector, NameSources, bool* foundTextAlternative) const;	213 String nativeTextAlternative(AXObjectSet& visited, AXNameFrom&, AXRelatedObj ectVector, NameSources, bool* foundTextAlternative) const;

214 float stepValueForRange() const;	214 float stepValueForRange() const;

215 bool isDescendantOfElementType(const HTMLQualifiedName& tagName) const;	215 bool isDescendantOfElementType(const HTMLQualifiedName& tagName) const;

216 };	216 };

217	217

218 } // namespace blink	218 } // namespace blink

219	219

220 #endif // AXNodeObject_h	220 #endif // AXNodeObject_h

OLD	NEW