Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed invisible to hidden to match ARIA Implementation Guide. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
index cf28e553d312c292124916237f4dd6051d5092b5..9e266fc14a077c5998e138284bac36cf3db75b92 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
@@ -1269,27 +1269,27 @@ String AXLayoutObject::textAlternative(bool recursive, bool inAriaLabelledByTrav
void AXLayoutObject::ariaFlowToElements(AXObjectVector& flowTo) const
{
- accessibilityChildrenFromAttribute(aria_flowtoAttr, flowTo);
+ accessibilityChildrenFromAttribute(aria_flowtoAttr, flowTo, false /* includeHiddenObjects */);
}
void AXLayoutObject::ariaControlsElements(AXObjectVector& controls) const
{
- accessibilityChildrenFromAttribute(aria_controlsAttr, controls);
+ accessibilityChildrenFromAttribute(aria_controlsAttr, controls, false /* includeHiddenObjects */);
}
void AXLayoutObject::ariaOwnsElements(AXObjectVector& owns) const
{
- accessibilityChildrenFromAttribute(aria_ownsAttr, owns);
+ accessibilityChildrenFromAttribute(aria_ownsAttr, owns, false /* includeHiddenObjects */);
}
void AXLayoutObject::ariaDescribedbyElements(AXObjectVector& describedby) const
{
- accessibilityChildrenFromAttribute(aria_describedbyAttr, describedby);
+ accessibilityChildrenFromAttribute(aria_describedbyAttr, describedby, true /* includeHiddenObjects */);
}
void AXLayoutObject::ariaLabelledbyElements(AXObjectVector& labelledby) const
{
- accessibilityChildrenFromAttribute(aria_labelledbyAttr, labelledby);
+ accessibilityChildrenFromAttribute(aria_labelledbyAttr, labelledby, true /* includeHiddenObjects */);
}
bool AXLayoutObject::ariaHasPopup() const

Powered by Google App Engine
This is Rietveld 408576698