third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp - Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed invisible to hidden to match ARIA Implementation Guide. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/accessibility/AXNodeObject.h ('K') | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.h ('k') | third_party/WebKit/Source/modules/accessibility/AXObject.h » ('j') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

index 176a48c22a4dae8e21ccf8f2e1964df99cea1061..0fac0ed59fead26b13e612665f76aace87a369f7 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

@@ -571,15 +571,18 @@ AccessibilityRole AXNodeObject::determineAriaRoleAttribute() const

return UnknownRole;

}

-void AXNodeObject::accessibilityChildrenFromAttribute(QualifiedName attr, AXObject::AXObjectVector& children) const

+void AXNodeObject::accessibilityChildrenFromAttribute(QualifiedName attr, AXObject::AXObjectVector& children, bool includeHiddenObjects) const

{

HeapVector<Member<Element>> elements;

elementsFromAttribute(elements, attr);

AXObjectCacheImpl& cache = axObjectCache();

for (const auto& element : elements) {

- if (AXObject* child = cache.getOrCreate(element))

+ if (AXObject* child = cache.getOrCreate(element)) {

+ if (!includeHiddenObjects && child->isHiddenForTextAlternativeCalculation())

aboxhall 2016/07/08 17:12:35 Why not just call child->accessibilityIsIgnored()

+ continue;

children.append(child);

+ }

}