Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1713)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 2112243004: Ignores ARIA relations (e.g. aria-labelledby) that point to an invisible target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed invisible to hidden to match ARIA Implementation Guide. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
index 93d5da6757c41e10e7d36ddac4e1e0927bdb45e7..fa5d1439879eee70d3087366286f91c720e0bf82 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
@@ -37,6 +37,7 @@
#include "core/html/HTMLFrameOwnerElement.h"
#include "core/html/parser/HTMLParserIdioms.h"
#include "core/layout/LayoutTheme.h"
+#include "core/style/ComputedStyleConstants.h"
#include "modules/accessibility/AXObjectCacheImpl.h"
#include "platform/UserGestureIndicator.h"
#include "platform/text/PlatformLocale.h"
@@ -900,8 +901,9 @@ void AXObject::elementsFromAttribute(HeapVector<Member<Element>>& elements, cons
TreeScope& scope = getNode()->treeScope();
for (const auto& id : ids) {
- if (Element* idElement = scope.getElementById(AtomicString(id)))
+ if (Element* idElement = scope.getElementById(AtomicString(id))) {
aboxhall 2016/07/08 17:12:35 Something weird happened here, does this file need
elements.append(idElement);
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698