Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2112223002: Revert of Add errors for declarations which conflict with catch parameters. (Closed)

Created:
4 years, 5 months ago by bakkot
Modified:
4 years, 5 months ago
Reviewers:
Dan Ehrenberg
CC:
adamk, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add errors for declarations which conflict with catch parameters. (patchset #6 id:100001 of https://codereview.chromium.org/2109733003/ ) Reason for revert: Fuzzer claims `try { \"\" ; } catch(x) { let x1 = [1,,], x = x; }` causes a crash. Original issue's description: > Add errors for declarations which conflict with catch parameters. > > Catch parameters are largely treated as lexical declarations in the > block which contains their body for the purposes of early syntax errors, > with some exceptions outlined in B.3.5. This patch introduces most of > those errors, except those from `eval('for (var e of ...);')` inside of > a catch with a simple parameter named 'e'. > > Note that annex B.3.5 allows var declarations to conflict with simple > catch parameters, except when the variable declaration is the init of a > for-of statement. > > BUG=v8:5112, v8:4231 > > Committed: https://crrev.com/2907c726b2bb5cf20b2bec639ca9e6a521585406 > Cr-Commit-Position: refs/heads/master@{#37462} TBR=littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5112, v8:4231 Committed: https://crrev.com/8834d5ecb559001c87c42322969471da60574a8c Cr-Commit-Position: refs/heads/master@{#37464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -461 lines) Patch
M src/ast/scopes.h View 4 chunks +3 lines, -17 lines 0 comments Download
M src/ast/scopes.cc View 5 chunks +5 lines, -23 lines 0 comments Download
M src/parsing/parser.cc View 11 chunks +35 lines, -84 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/block-conflicts.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/es6/block-conflicts-sloppy.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/es6/block-sloppy-function.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/mjsunit/es6/catch-parameter-redeclaration.js View 1 chunk +0 lines, -104 lines 0 comments Download
D test/mjsunit/es6/for-each-in-catch.js View 1 chunk +0 lines, -193 lines 0 comments Download
M test/test262/test262.status View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
bakkot
Created Revert of Add errors for declarations which conflict with catch parameters.
4 years, 5 months ago (2016-07-01 04:21:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112223002/1
4 years, 5 months ago (2016-07-01 04:21:46 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-01 04:21:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112223002/1
4 years, 5 months ago (2016-07-01 04:23:05 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-01 04:23:10 UTC) #10
Dan Ehrenberg
lgtm
4 years, 5 months ago (2016-07-01 04:26:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112223002/1
4 years, 5 months ago (2016-07-01 04:26:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 04:26:50 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 04:26:53 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8834d5ecb559001c87c42322969471da60574a8c Cr-Commit-Position: refs/heads/master@{#37464}
4 years, 5 months ago (2016-07-01 04:29:12 UTC) #17
bakkot
4 years, 5 months ago (2016-07-01 19:04:39 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2119933002/ by bakkot@google.com.

The reason for reverting is: Correcting issue..

Powered by Google App Engine
This is Rietveld 408576698