Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1307)

Unified Diff: test/mjsunit/es6/catch-parameter-redeclaration.js

Issue 2112223002: Revert of Add errors for declarations which conflict with catch parameters. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/es6/block-sloppy-function.js ('k') | test/mjsunit/es6/for-each-in-catch.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/es6/catch-parameter-redeclaration.js
diff --git a/test/mjsunit/es6/catch-parameter-redeclaration.js b/test/mjsunit/es6/catch-parameter-redeclaration.js
deleted file mode 100644
index 0d6ce061f8c526538eda91e3f24a3f81fd301ad4..0000000000000000000000000000000000000000
--- a/test/mjsunit/es6/catch-parameter-redeclaration.js
+++ /dev/null
@@ -1,104 +0,0 @@
-// Copyright 2016 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-function checkIsRedeclarationError(code) {
- try {
- eval(`
-checkIsRedeclarationError : {
- break checkIsRedeclarationError;
-${code}
-}
-`);
- assertUnreachable();
- } catch(e) {
- assertInstanceof(e, SyntaxError );
- assertTrue( e.toString().indexOf("has already been declared") >= 0 );
- }
-}
-
-function checkIsNotRedeclarationError(code) {
- assertDoesNotThrow(()=>eval(`
-checkIsNotRedeclarationError_label : {
- break checkIsNotRedeclarationError_label;
-${code}
-}
-`));
-}
-
-
-let lexical_e = [
- 'let e',
- 'let {e} = 0',
- 'let [e] = 0',
- 'let {f:e} = 0',
- 'let [[[], e]] = 0',
- 'const e = 0',
- 'const {e} = 0',
- 'const [e] = 0',
- 'const {f:e} = 0',
- 'const [[[], e]] = 0',
- 'function e(){}',
- 'function* e(){}',
-];
-
-let not_lexical_e = [
- 'var e',
- 'var {e} = 0',
- 'let {} = 0',
- 'let {e:f} = 0',
- '{ function e(){} }'
-];
-
-// Check that lexical declarations cannot override a simple catch parameter
-for (let declaration of lexical_e) {
- checkIsRedeclarationError(`
-try {
- throw 0;
-} catch(e) {
- ${declaration}
-}
-`);
-}
-
-// Check that lexical declarations cannot override a complex catch parameter
-for (let declaration of lexical_e) {
- checkIsRedeclarationError(`
-try {
- throw 0;
-} catch({e}) {
- ${declaration}
-}
-`);
-}
-
-// Check that non-lexical declarations can override a simple catch parameter
-for (let declaration of not_lexical_e) {
- checkIsNotRedeclarationError(`
-try {
- throw 0;
-} catch(e) {
- ${declaration}
-}
-`);
-}
-
-// Check that the above error does not occur if a declaration scope is between
-// the catch and the loop.
-for (let declaration of lexical_e) {
- checkIsNotRedeclarationError(`
-try {
- throw 0;
-} catch(e) {
- (()=>{${declaration}})();
-}
-`);
-
- checkIsNotRedeclarationError(`
-try {
- throw 0;
-} catch(e) {
- (function(){${declaration}})();
-}
-`);
-}
« no previous file with comments | « test/mjsunit/es6/block-sloppy-function.js ('k') | test/mjsunit/es6/for-each-in-catch.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698