Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2112093002: Mojo C++ bindings: Merge EncodePointers/DecodePointers into Serialize/Deserialize, respectively. (Closed)

Created:
4 years, 5 months ago by yzshen1
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@61_array_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: Merge EncodePointers/DecodePointers into Serialize/Deserialize, respectively. This improves performance because it reduces the number of passes that we need to walk the data structure being serialized/deserialized. It also simplifies things. BUG=624459 Committed: https://crrev.com/a601f0335f8a35e3a51031a2116d48b319823597 Cr-Commit-Position: refs/heads/master@{#403464}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -547 lines) Patch
M mojo/mojo_public.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/array_internal.h View 9 chunks +12 lines, -76 lines 0 comments Download
M mojo/public/cpp/bindings/lib/array_serialization.h View 1 6 chunks +15 lines, -27 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_internal.h View 1 7 chunks +37 lines, -7 lines 0 comments Download
A + mojo/public/cpp/bindings/lib/bindings_internal.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_handler.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_proxy.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/map_data_internal.h View 2 chunks +10 lines, -43 lines 0 comments Download
M mojo/public/cpp/bindings/lib/map_serialization.h View 2 chunks +11 lines, -9 lines 0 comments Download
M mojo/public/cpp/bindings/lib/native_struct_data.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/pipe_control_message_handler.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/serialization.h View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/lib/serialization_util.h View 1 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/public/cpp/bindings/lib/serialization_util.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M mojo/public/cpp/bindings/lib/validation_util.h View 3 chunks +19 lines, -36 lines 0 comments Download
M mojo/public/cpp/bindings/tests/array_common_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/union_unittest.cc View 21 chunks +4 lines, -43 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_declaration.tmpl View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_definition.tmpl View 1 chunk +0 lines, -37 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 1 chunk +0 lines, -25 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 1 2 chunks +8 lines, -10 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/validation_macros.tmpl View 1 chunk +3 lines, -10 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 3 chunks +2 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 5 months ago (2016-06-30 23:45:57 UTC) #2
Ken Rockot(use gerrit already)
Wow, so much deleted code. Lgtm!
4 years, 5 months ago (2016-07-01 00:36:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112093002/20001
4 years, 5 months ago (2016-07-01 15:39:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 16:14:32 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 16:14:36 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 16:16:33 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a601f0335f8a35e3a51031a2116d48b319823597
Cr-Commit-Position: refs/heads/master@{#403464}

Powered by Google App Engine
This is Rietveld 408576698