mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl - Issue 2112093002: Mojo C++ bindings: Merge EncodePointers/DecodePointers into Serialize/Deserialize, respectively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

Issue 2112093002: Mojo C++ bindings: Merge EncodePointers/DecodePointers into Serialize/Deserialize, respectively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@61_array_fix

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

index 78bb4322b12cba54bbc8473aba7737e32d3ac1dc..7c3493924c0ac94024f1ef2951cefa250cad8411 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

@@ -13,9 +13,9 @@ class {{struct.name}}DataView {

bool Read{{name|under_to_camel}}(UserType* value) {

{%- if pf.min_version != 0 %}

auto pointer = data_->header_.version >= {{pf.min_version}}

- ? data_->{{name}}.ptr : nullptr;

+ ? data_->{{name}}.Get() : nullptr;

{%- else %}

- auto pointer = data_->{{name}}.ptr;

+ auto pointer = data_->{{name}}.Get();

{%- endif %}

return mojo::internal::Deserialize<{{kind|unmapped_type_for_serializer}}>(

pointer, value, context_);