mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc - Issue 2112093002: Mojo C++ bindings: Merge EncodePointers/DecodePointers into Serialize/Deserialize, respectively.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc

Issue 2112093002: Mojo C++ bindings: Merge EncodePointers/DecodePointers into Serialize/Deserialize, respectively. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@61_array_fix

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc

diff --git a/mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc b/mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc

index 7a160ff71838df2260be4bf8218af448e713d560..55ee64bb27149421a11084efbe83559fdf31c52d 100644

--- a/mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc

+++ b/mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc

@@ -33,7 +33,6 @@ void SendRunOrClosePipeMessage(MessageReceiver* receiver,

pipe_control::internal::RunOrClosePipeMessageParams_Data* params = nullptr;

internal::Serialize<pipe_control::RunOrClosePipeMessageParamsPtr>(

params_ptr, builder.buffer(), &params, context);

- params->EncodePointers();

builder.message()->set_interface_id(kInvalidInterfaceId);

bool ok = receiver->Accept(builder.message());

// This return value may be ignored as !ok implies the underlying message pipe

« no previous file with comments | « mojo/public/cpp/bindings/lib/pipe_control_message_handler.cc ('k') | mojo/public/cpp/bindings/lib/serialization.h » ('j') | no next file with comments »