components/gcm_driver/instance_id/instance_id_driver.h - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/instance_id_driver.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: Address jianli's review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/gcm_client_impl.h ('K') | « components/gcm_driver/instance_id/instance_id_android.cc ('k') | components/gcm_driver/instance_id/instance_id_driver.cc » ('j') | google_apis/gcm/engine/gcm_request_test_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/instance_id/instance_id_driver.h

diff --git a/components/gcm_driver/instance_id/instance_id_driver.h b/components/gcm_driver/instance_id/instance_id_driver.h

index 38e1e6224b93c61c654b6b376b95d055daccb36e..f0ff94242889353db59a1713067c02b52d1e29b4 100644

--- a/components/gcm_driver/instance_id/instance_id_driver.h

+++ b/components/gcm_driver/instance_id/instance_id_driver.h

@@ -30,7 +30,7 @@ class InstanceIDDriver {

virtual ~InstanceIDDriver();

// Returns the InstanceID that provides the Instance ID service for the given

- // application. The lifetime of InstanceID will be managed by this class.

+ // application. The lifetime of the InstanceID will be managed by this class.

InstanceID* GetInstanceID(const std::string& app_id);

// Removes the InstanceID when it is not longer needed, i.e. the app is being