components/gcm_driver/instance_id/instance_id_driver.cc - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/instance_id_driver.cc

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: Address jianli's review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/gcm_client_impl.h ('K') | « components/gcm_driver/instance_id/instance_id_driver.h ('k') | components/gcm_driver/instance_id/instance_id_impl.cc » ('j') | google_apis/gcm/engine/gcm_request_test_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/instance_id/instance_id_driver.cc

diff --git a/components/gcm_driver/instance_id/instance_id_driver.cc b/components/gcm_driver/instance_id/instance_id_driver.cc

index 3cd96b70091ec8e1a8da4c828ab11d99754eca16..8e0345b04d6ba853ce84aaef64f5840305cd0639 100644

--- a/components/gcm_driver/instance_id/instance_id_driver.cc

+++ b/components/gcm_driver/instance_id/instance_id_driver.cc

@@ -38,7 +38,7 @@ InstanceID* InstanceIDDriver::GetInstanceID(const std::string& app_id) {

return iter->second.get();

std::unique_ptr<InstanceID> instance_id =

- InstanceID::Create(app_id, gcm_driver_);

+ InstanceID::CreateInternal(app_id, gcm_driver_);

InstanceID* instance_id_ptr = instance_id.get();

instance_id_map_.insert(std::make_pair(app_id, std::move(instance_id)));

return instance_id_ptr;