components/gcm_driver/gcm_client_impl.h - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_client_impl.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: Address jianli's review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/gcm_client_impl.h

diff --git a/components/gcm_driver/gcm_client_impl.h b/components/gcm_driver/gcm_client_impl.h

index f4cc121a59938692bfcae8a96bf3a2f6756c6d60..1dd875764e391c89ccf95e899bb38cbc53ef4547 100644

--- a/components/gcm_driver/gcm_client_impl.h

+++ b/components/gcm_driver/gcm_client_impl.h

@@ -283,12 +283,15 @@ class GCMClientImpl

// Fires OnMessageReceived event on the delegate of this class, based on the

// details in |data_message_stanza| and |message_data|.

void HandleIncomingDataMessage(

+ const std::string& app_id,

+ bool was_subtype,

const mcs_proto::DataMessageStanza& data_message_stanza,

MessageData& message_data);

// Fires OnMessageSendError event on the delegate of this calss, based on the

Nicolas Zea 2016/08/17 20:54:09 nit: calss -> class

johnme 2016/08/18 17:43:21 Done.

// details in |data_message_stanza| and |message_data|.

void HandleIncomingSendError(

+ const std::string& app_id,

const mcs_proto::DataMessageStanza& data_message_stanza,

MessageData& message_data);

« components/gcm_driver/DEPS ('K') | « components/gcm_driver/gcm_client.h ('k') | components/gcm_driver/gcm_client_impl.cc » ('j') | google_apis/gcm/engine/gcm_request_test_base.h » ('J')