Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11418)

Unified Diff: components/gcm_driver/DEPS

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: Address jianli's review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/DEPS
diff --git a/components/gcm_driver/DEPS b/components/gcm_driver/DEPS
index 274a83906a13d4281ddd9ac5f4c721576a764303..039ab86b73e1dd334259664c39fc7ddf046aa9d9 100644
--- a/components/gcm_driver/DEPS
+++ b/components/gcm_driver/DEPS
@@ -1,4 +1,5 @@
include_rules = [
+ "+components/crx_file/id_util.h",
"+components/os_crypt",
"+components/keyed_service",
"+components/pref_registry",
@@ -8,8 +9,7 @@ include_rules = [
"+components/sync_driver",
"+components/timers", # Only used for Chrome OS builds.
"+components/version_info",
- # TODO(johnme): Fix this layering violation.
- "!content/public/android/java",
+ "+content/public/android/java",
Nicolas Zea 2016/08/17 20:54:09 My understanding was that components should never
johnme 2016/08/18 17:43:21 components/README says "Individual components may
"+google_apis/gaia",
"+google_apis/gcm",
"+jni",

Powered by Google App Engine
This is Rietveld 408576698