components/gcm_driver/DEPS - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/gcm_driver/DEPS

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: Address jianli's review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+components/crx_file/id_util.h",

2 "+components/os_crypt",	3 "+components/os_crypt",

3 "+components/keyed_service",	4 "+components/keyed_service",

4 "+components/pref_registry",	5 "+components/pref_registry",

5 "+components/prefs",	6 "+components/prefs",

6 "+components/signin",	7 "+components/signin",

7 "+components/sync/protocol",	8 "+components/sync/protocol",

8 "+components/sync_driver",	9 "+components/sync_driver",

9 "+components/timers", # Only used for Chrome OS builds.	10 "+components/timers", # Only used for Chrome OS builds.

10 "+components/version_info",	11 "+components/version_info",

11 # TODO(johnme): Fix this layering violation.	12 "+content/public/android/java",
	Nicolas Zea 2016/08/17 20:54:09 My understanding was that components should never My understanding was that components should never depend on content/? johnme 2016/08/18 17:43:21 components/README says "Individual components may Show quoted text On 2016/08/17 20:54:09, Nicolas Zea wrote: > My understanding was that components should never depend on content/? components/README says "Individual components may additionally allow dependencies on the content API and IPC". components/ code used by iOS can't depend on content/, but this DEPS rule is Android-only so that's not a problem in this case.
12 "!content/public/android/java",

13 "+google_apis/gaia",	13 "+google_apis/gaia",

14 "+google_apis/gcm",	14 "+google_apis/gcm",

15 "+jni",	15 "+jni",

16 "+net",	16 "+net",

17 ]	17 ]

OLD	NEW

« chrome/browser/services/gcm/gcm_product_util.h ('K') | « components/gcm_driver/BUILD.gn ('k') | components/gcm_driver/fake_gcm_client.h » ('j') | components/gcm_driver/gcm_client_impl.h » ('J')