Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()

Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()

Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
lock and potentially touches the disk to obtain the VS_VERSION_INFO
of the module. This is gratuitous for a module that is already loaded.

With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
resource from memory.

First version of this CL: https://codereview.chromium.org/2046583002/

TBR=thestig@chromium.org
BUG=609709
Committed: https://crrev.com/5b7de9e98e0ec2dab0715758d2d5f5d00158a7c0
Cr-Commit-Position: refs/heads/master@{#402985}

[fdoray, 2016-06-29 18:27:54]

Description was changed from

==========
Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()

Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
lock and potentially touches the disk to obtain the VS_VERSION_INFO
of the module. This is gratuitous for a module that is already loaded.

With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
resource from memory.

First version of this CL: https://codereview.chromium.org/2046583002/

BUG=609709
==========

to

==========
Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()

Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
lock and potentially touches the disk to obtain the VS_VERSION_INFO
of the module. This is gratuitous for a module that is already loaded.

With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
resource from memory.

First version of this CL: https://codereview.chromium.org/2046583002/

TBR=thestig@chromium.org
BUG=609709
==========

[fdoray, 2016-06-29 18:27:54]

fdoray@chromium.org changed reviewers:
+ thestig@chromium.org

[fdoray, 2016-06-29 18:29:35]

thestig@: PTAL. This is identical to https://codereview.chromium.org/2046583002/
% a fix for the Win x64 build.

[fdoray, 2016-06-29 18:29:42]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-06-29 18:30:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-06-29 18:31:56]

lgtm

[commit-bot: I haz the power, 2016-06-29 19:35:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 19:35:19]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[fdoray, 2016-06-29 21:40:37]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-06-29 21:49:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 23:13:31]

Description was changed from

==========
Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()

Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
lock and potentially touches the disk to obtain the VS_VERSION_INFO
of the module. This is gratuitous for a module that is already loaded.

With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
resource from memory.

First version of this CL: https://codereview.chromium.org/2046583002/

TBR=thestig@chromium.org
BUG=609709
==========

to

==========
Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()

Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
lock and potentially touches the disk to obtain the VS_VERSION_INFO
of the module. This is gratuitous for a module that is already loaded.

With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
resource from memory.

First version of this CL: https://codereview.chromium.org/2046583002/

TBR=thestig@chromium.org
BUG=609709
==========

[commit-bot: I haz the power, 2016-06-29 23:13:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 23:16:55]

Description was changed from

==========
Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()

Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
lock and potentially touches the disk to obtain the VS_VERSION_INFO
of the module. This is gratuitous for a module that is already loaded.

With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
resource from memory.

First version of this CL: https://codereview.chromium.org/2046583002/

TBR=thestig@chromium.org
BUG=609709
==========

to

==========
Don't use ::GetFileVersionInfo() in CreateFileVersionInfoForModule()

Currently, base::FileVersionInfo::CreateFileVersionInfoForModule()
calls ::GetModuleFileName and ::GetFileVersionInfo, grabs the loader
lock and potentially touches the disk to obtain the VS_VERSION_INFO
of the module. This is gratuitous for a module that is already loaded.

With this CL, base::FileVersionInfo::CreateFileVersionInfoForModule()
uses base::win::GetResourceFromModule() to get the VS_VERSION_INFO
resource from memory.

First version of this CL: https://codereview.chromium.org/2046583002/

TBR=thestig@chromium.org
BUG=609709

Committed: https://crrev.com/5b7de9e98e0ec2dab0715758d2d5f5d00158a7c0
Cr-Commit-Position: refs/heads/master@{#402985}
==========

[commit-bot: I haz the power, 2016-06-29 23:16:56]

Patchset 2 (id:??) landed as
https://crrev.com/5b7de9e98e0ec2dab0715758d2d5f5d00158a7c0
Cr-Commit-Position: refs/heads/master@{#402985}